Changes between Initial Version and Version 1 of Ticket #25388, comment 17


Ignore:
Timestamp:
09/10/18 16:52:26 (4 years ago)
Author:
nbruin
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #25388, comment 17

    initial v1  
    11Looking at the code referenced in your commits: Indeed, it looks to me these objects have no business being `UniqueRepresentation`. They are differentials: elements; morphisms. There's no need for those to have their equality determined by their ID, which is what `UniqueRepresentation` is for. Indeed, needing comparison inheritance shows that they are not `UniqueRepresentation`. The right way to "fix" this (if any fix is necessary) is to change the inheritance of these objects, not to introduce an oxymoronic new class.
     2
     3It could be that those pieces of code are from before `UniqueRepresentation` and `CachedRepresentation` were split off, or perhaps they were written by someone who didn't understand the fine difference between the two. In this case, I don't think you would even want to do it as a transition, since you're causing a net increase in code, so it's not making it shorter either.