Opened 4 years ago

Closed 4 years ago

#25387 closed defect (fixed)

Clean up UniqueRepresentations in sage.algebra (part 1)

Reported by: embray Owned by:
Priority: major Milestone: sage-8.3
Component: algebra Keywords:
Cc: Merged in:
Authors: Erik Bray Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: bc9af5f (Commits, GitHub, GitLab) Commit: bc9af5f6df396432c37aa47e82286ec8ea44b3c6
Dependencies: Stopgaps:

Status badges

Description

Motivated by ​this comment, this removes some needless explicit __eq__ and __ne__ implementations from some classes in sage.algebras that subclass (directly or indirectly) UniqueRepresentation.

This also fixes problems with these classes on Python w.r.t. #24551. There are likely other cases like this but I'm just looking one top-level sub-package at a time...

Change History (5)

comment:1 Changed 4 years ago by embray

  • Status changed from new to needs_review

comment:2 Changed 4 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok

comment:3 Changed 4 years ago by chapoton

Very high priority should be given to handling the hash problem in sage/manifold.

Because issues there create a lot of error in doc-building :

​https://patchbot.sagemath.org/log/0/Ubuntu/18.04/x86_64/4.15.0-20-generic/petitbonum/2018-05-17%2015:22:17?plugin=docbuild

Version 1, edited 4 years ago by chapoton (previous) (next) (diff)

comment:4 Changed 4 years ago by embray

I have temporary fixes to most of those in my python3 branch. But I'd like to take another look if any of those fall into a similar category as this ticket.

comment:5 Changed 4 years ago by vbraun

  • Branch changed from u/embray/misc/unique-repr/algebras-1 to bc9af5f6df396432c37aa47e82286ec8ea44b3c6
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.