#2536 closed enhancement (fixed)
Deprecate SageObject.db and SageObject.version
Reported by:  was  Owned by:  cwitty 

Priority:  major  Milestone:  sage6.5 
Component:  misc  Keywords:  
Cc:  mkoeppe  Merged in:  
Authors:  André Apitzsch  Reviewers:  KarlDieter Crisman 
Report Upstream:  N/A  Work issues:  
Branch:  1f84eb4 (Commits, GitHub, GitLab)  Commit:  
Dependencies:  Stopgaps: 
Description
Hi,
I wrote db and version methods that all SageObjects? have. It seemed like a good idea at the time. They didn't catch on  nobody finds this interesting, etc. I vote for completely removing them from Sage.
Change History (16)
comment:1 Changed 14 years ago by
 Type changed from defect to enhancement
comment:2 Changed 9 years ago by
 Milestone changed from sage5.11 to sage5.12
comment:3 Changed 9 years ago by
 Milestone changed from sage6.1 to sage6.2
comment:4 Changed 8 years ago by
 Milestone changed from sage6.2 to sage6.3
comment:5 Changed 8 years ago by
 Milestone changed from sage6.3 to sage6.4
comment:6 Changed 8 years ago by
 Branch set to u/aapitzsch/ticket/2536
 Commit set to 6884d7d9502bea079eb1e8931bbb8b8a6bf14b6a
 Report Upstream set to N/A
 Status changed from new to needs_review
 Summary changed from get rid of SageObject.db and SageObject.version everywhere  these turned out to "not catch on" to Deprecate SageObject.db and SageObject.version everywhere  these turned out to "not catch on"
comment:7 followup: ↓ 9 Changed 8 years ago by
 Summary changed from Deprecate SageObject.db and SageObject.version everywhere  these turned out to "not catch on" to Deprecate SageObject.db and SageObject.version
comment:8 Changed 8 years ago by
 Commit changed from 6884d7d9502bea079eb1e8931bbb8b8a6bf14b6a to bc78815d35c98c23f0f0b3c1bc4509f2b918c717
Branch pushed to git repo; I updated commit sha1. New commits:
bc78815  doctest deprecations

comment:9 in reply to: ↑ 7 Changed 8 years ago by
Replying to kcrisman:
I realize this seems silly for something no one uses, but perhaps we should doctest these deprecations?
Added doctests.
comment:10 Changed 8 years ago by
 Milestone changed from sage6.4 to sage6.5
 Reviewers set to KarlDieter Crisman
 Status changed from needs_review to positive_review
I'm a little surprised that doctest works since it does return a value, but I guess the :...
covers that instead of the usual :...:
. Running doctests again but hopefully all is well.
comment:11 Changed 8 years ago by
 Status changed from positive_review to needs_work
Expected: Help on FiniteWordPath_2d_str in module sage.combinat.words.paths object: ... Methods inherited from FiniteWordPath_2d: ... Methods inherited from FiniteWordPath_all: ... This only works on Python classes that derive from SageObject. Got: <stuff ending with>  This only works on Python classes that derive from SageObject.   TESTS::   sage: v = DiGraph().version()  doctest:... DeprecationWarning: version() is deprecated.  See http://trac.sagemath.org/2536 for details.  sage t src/sage/combinat/words/paths.py # 1 doctest failed
Otherwise all is well. I guess this is my fault for asking for the deprecation warning after you did your long doctests, my apologies.
comment:12 Changed 8 years ago by
 Commit changed from bc78815d35c98c23f0f0b3c1bc4509f2b918c717 to 1f84eb4d20a4c3d831128befd4d84d6acbe8ad39
Branch pushed to git repo; I updated commit sha1. New commits:
1f84eb4  fix failing doctest

comment:13 Changed 8 years ago by
 Status changed from needs_work to needs_review
comment:14 Changed 8 years ago by
 Status changed from needs_review to positive_review
comment:15 Changed 7 years ago by
 Branch changed from u/aapitzsch/ticket/2536 to 1f84eb4d20a4c3d831128befd4d84d6acbe8ad39
 Resolution set to fixed
 Status changed from positive_review to closed
comment:16 Changed 6 years ago by
 Cc mkoeppe added
 Commit 1f84eb4d20a4c3d831128befd4d84d6acbe8ad39 deleted
#20376 uses db()
for purposes of logging/debugging...
I realize this seems silly for something no one uses, but perhaps we should doctest these deprecations?