#25353 closed defect (fixed)

fflas and linbox broken with gcc 8.1.0

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-8.3
Component: packages: standard Keywords: fflas, linbox, gcc-8
Cc: cpernet, slelievre Merged in:
Authors: Clement Pernet Reviewers: Julian Rüth
Report Upstream: Fixed upstream, but not in a stable release. Work issues:
Branch: cb566ea (Commits) Commit: cb566ea35dc8e494ca3a8f0720b0a7f76c1386c1
Dependencies: Stopgaps:

Description

In file included from ../../linbox/matrix/densematrix/blas-matrix.h:54,
                 from ../../linbox/matrix/dense-matrix.h:79,
                 from ../../linbox/algorithms/rational-solver.h:43,
                 from ../../linbox/algorithms/diophantine-solver.h:29,
                 from diophantine-solver.C:26:
../../linbox/matrix/densematrix/blas-transposed-matrix.h:74:8: error: too many template-parameter-lists
  class TransposedBlasMatrix< TransposedBlasMatrix< Matrix > > : public Matrix {
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../../../../../../../include/fflas-ffpack/fflas/fflas_simd/simd256.inl:186,
                 from ../../../../../../../../include/fflas-ffpack/fflas/fflas_simd.h:208,
                 from ../../../../../../../../include/fflas-ffpack/fflas/fflas_freduce.h:33,
                 from ../../../../../../../../include/fflas-ffpack/fflas/fflas.h:104,
                 from ../../../../../../../../include/fflas-ffpack/ffpack/ffpack.h:47,
                 from ../../linbox/matrix/matrixdomain/blas-matrix-domain.h:45,
                 from ../../linbox/matrix/matrix-domain.h:68,
                 from ../../linbox/matrix/transpose-matrix.h:47,
                 from ../../linbox/matrix/matrixdomain/matrix-domain.inl:34,
                 from ../../linbox/matrix/matrixdomain/matrix-domain.h:1233,
                 from ../../linbox/matrix/densematrix/blas-matrix.h:55,
                 from ../../linbox/matrix/dense-matrix.h:79,
                 from ../../linbox/algorithms/rational-solver.h:43,
                 from ../../linbox/algorithms/diophantine-solver.h:29,
                 from diophantine-solver.C:26:
../../../../../../../../include/fflas-ffpack/fflas/fflas_simd/simd256_int64.inl:247:90: warning: 'const' attribute on function returning 'void' [-Wattributes]
  static INLINE CONST void unpacklohi(vect_t& l, vect_t& h, const vect_t a, const vect_t b) {
                                                                                          ^
In file included from ../../../../../../../../include/fflas-ffpack/fflas/fflas_simd/simd256.inl:187,
                 from ../../../../../../../../include/fflas-ffpack/fflas/fflas_simd.h:208,
                 from ../../../../../../../../include/fflas-ffpack/fflas/fflas_freduce.h:33,
                 from ../../../../../../../../include/fflas-ffpack/fflas/fflas.h:104,
                 from ../../../../../../../../include/fflas-ffpack/ffpack/ffpack.h:47,
                 from ../../linbox/matrix/matrixdomain/blas-matrix-domain.h:45,
                 from ../../linbox/matrix/matrix-domain.h:68,
                 from ../../linbox/matrix/transpose-matrix.h:47,
                 from ../../linbox/matrix/matrixdomain/matrix-domain.inl:34,
                 from ../../linbox/matrix/matrixdomain/matrix-domain.h:1233,
                 from ../../linbox/matrix/densematrix/blas-matrix.h:55,
                 from ../../linbox/matrix/dense-matrix.h:79,
                 from ../../linbox/algorithms/rational-solver.h:43,
                 from ../../linbox/algorithms/diophantine-solver.h:29,
                 from diophantine-solver.C:26:
../../../../../../../../include/fflas-ffpack/fflas/fflas_simd/simd256_int32.inl:258:92: warning: 'const' attribute on function returning 'void' [-Wattributes]
  static INLINE CONST void unpacklohi(vect_t& s1, vect_t& s2, const vect_t a, const vect_t b) {
                                                                                            ^
In file included from ../../../../../../../../include/fflas-ffpack/fflas/fflas_simd/simd256.inl:188,
                 from ../../../../../../../../include/fflas-ffpack/fflas/fflas_simd.h:208,
                 from ../../../../../../../../include/fflas-ffpack/fflas/fflas_freduce.h:33,
                 from ../../../../../../../../include/fflas-ffpack/fflas/fflas.h:104,
                 from ../../../../../../../../include/fflas-ffpack/ffpack/ffpack.h:47,
                 from ../../linbox/matrix/matrixdomain/blas-matrix-domain.h:45,
                 from ../../linbox/matrix/matrix-domain.h:68,
                 from ../../linbox/matrix/transpose-matrix.h:47,
                 from ../../linbox/matrix/matrixdomain/matrix-domain.inl:34,
                 from ../../linbox/matrix/matrixdomain/matrix-domain.h:1233,
                 from ../../linbox/matrix/densematrix/blas-matrix.h:55,
                 from ../../linbox/matrix/dense-matrix.h:79,
                 from ../../linbox/algorithms/rational-solver.h:43,
                 from ../../linbox/algorithms/diophantine-solver.h:29,
                 from diophantine-solver.C:26:
../../../../../../../../include/fflas-ffpack/fflas/fflas_simd/simd256_int16.inl:258:92: warning: 'const' attribute on function returning 'void' [-Wattributes]
  static INLINE CONST void unpacklohi(vect_t& s1, vect_t& s2, const vect_t a, const vect_t b) {

Change History (11)

comment:1 Changed 18 months ago by vdelecroix

Solve the const void in fflas with

$ sed -i s/INLINE\ CONST\ void/INLINE\ void/g $(find . -name "*inl")

comment:2 Changed 18 months ago by vdelecroix

  • Summary changed from linbox fail to build with gcc 8.1.0 to fflas and linbox broken with gcc 8.1.0

comment:4 Changed 18 months ago by cpernet

  • Branch set to u/cpernet/fflas_and_linbox_broken_with_gcc_8_1_0

comment:5 Changed 18 months ago by cpernet

  • Branch u/cpernet/fflas_and_linbox_broken_with_gcc_8_1_0 deleted

I agree with the proposed fixes for fflas given here and the simple removal of the double template proposed on sage-devel by fidelbc and Dario Asprone. I have fixed both libraries upstream and add the corresponding patches to the branch for this ticket.

comment:6 Changed 18 months ago by cpernet

  • Branch set to u/cpernet/fflas_and_linbox_broken_with_gcc_8_1_0

comment:7 Changed 18 months ago by slelievre

  • Cc slelievre added
  • Commit set to cb566ea35dc8e494ca3a8f0720b0a7f76c1386c1
  • Keywords fflas linbox gcc-8 added

Don't forget to set to "needs review" if this is ready for review.


New commits:

cb566eafixing gcc-8.1 compilation errors.

comment:8 Changed 18 months ago by cpernet

  • Authors set to Clement Pernet
  • Status changed from new to needs_review

comment:9 Changed 18 months ago by slelievre

  • Report Upstream changed from N/A to Fixed upstream, but not in a stable release.

comment:10 Changed 18 months ago by saraedum

  • Reviewers set to Julian Rüth
  • Status changed from needs_review to positive_review

comment:11 Changed 18 months ago by vbraun

  • Branch changed from u/cpernet/fflas_and_linbox_broken_with_gcc_8_1_0 to cb566ea35dc8e494ca3a8f0720b0a7f76c1386c1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.