Opened 3 years ago
Closed 3 years ago
#25353 closed defect (fixed)
fflas and linbox broken with gcc 8.1.0
Reported by:  vdelecroix  Owned by:  

Priority:  major  Milestone:  sage8.3 
Component:  packages: standard  Keywords:  fflas, linbox, gcc8 
Cc:  cpernet, slelievre  Merged in:  
Authors:  Clement Pernet  Reviewers:  Julian Rüth 
Report Upstream:  Fixed upstream, but not in a stable release.  Work issues:  
Branch:  cb566ea (Commits, GitHub, GitLab)  Commit:  cb566ea35dc8e494ca3a8f0720b0a7f76c1386c1 
Dependencies:  Stopgaps: 
Description
In file included from ../../linbox/matrix/densematrix/blasmatrix.h:54, from ../../linbox/matrix/densematrix.h:79, from ../../linbox/algorithms/rationalsolver.h:43, from ../../linbox/algorithms/diophantinesolver.h:29, from diophantinesolver.C:26: ../../linbox/matrix/densematrix/blastransposedmatrix.h:74:8: error: too many templateparameterlists class TransposedBlasMatrix< TransposedBlasMatrix< Matrix > > : public Matrix { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from ../../../../../../../../include/fflasffpack/fflas/fflas_simd/simd256.inl:186, from ../../../../../../../../include/fflasffpack/fflas/fflas_simd.h:208, from ../../../../../../../../include/fflasffpack/fflas/fflas_freduce.h:33, from ../../../../../../../../include/fflasffpack/fflas/fflas.h:104, from ../../../../../../../../include/fflasffpack/ffpack/ffpack.h:47, from ../../linbox/matrix/matrixdomain/blasmatrixdomain.h:45, from ../../linbox/matrix/matrixdomain.h:68, from ../../linbox/matrix/transposematrix.h:47, from ../../linbox/matrix/matrixdomain/matrixdomain.inl:34, from ../../linbox/matrix/matrixdomain/matrixdomain.h:1233, from ../../linbox/matrix/densematrix/blasmatrix.h:55, from ../../linbox/matrix/densematrix.h:79, from ../../linbox/algorithms/rationalsolver.h:43, from ../../linbox/algorithms/diophantinesolver.h:29, from diophantinesolver.C:26: ../../../../../../../../include/fflasffpack/fflas/fflas_simd/simd256_int64.inl:247:90: warning: 'const' attribute on function returning 'void' [Wattributes] static INLINE CONST void unpacklohi(vect_t& l, vect_t& h, const vect_t a, const vect_t b) { ^ In file included from ../../../../../../../../include/fflasffpack/fflas/fflas_simd/simd256.inl:187, from ../../../../../../../../include/fflasffpack/fflas/fflas_simd.h:208, from ../../../../../../../../include/fflasffpack/fflas/fflas_freduce.h:33, from ../../../../../../../../include/fflasffpack/fflas/fflas.h:104, from ../../../../../../../../include/fflasffpack/ffpack/ffpack.h:47, from ../../linbox/matrix/matrixdomain/blasmatrixdomain.h:45, from ../../linbox/matrix/matrixdomain.h:68, from ../../linbox/matrix/transposematrix.h:47, from ../../linbox/matrix/matrixdomain/matrixdomain.inl:34, from ../../linbox/matrix/matrixdomain/matrixdomain.h:1233, from ../../linbox/matrix/densematrix/blasmatrix.h:55, from ../../linbox/matrix/densematrix.h:79, from ../../linbox/algorithms/rationalsolver.h:43, from ../../linbox/algorithms/diophantinesolver.h:29, from diophantinesolver.C:26: ../../../../../../../../include/fflasffpack/fflas/fflas_simd/simd256_int32.inl:258:92: warning: 'const' attribute on function returning 'void' [Wattributes] static INLINE CONST void unpacklohi(vect_t& s1, vect_t& s2, const vect_t a, const vect_t b) { ^ In file included from ../../../../../../../../include/fflasffpack/fflas/fflas_simd/simd256.inl:188, from ../../../../../../../../include/fflasffpack/fflas/fflas_simd.h:208, from ../../../../../../../../include/fflasffpack/fflas/fflas_freduce.h:33, from ../../../../../../../../include/fflasffpack/fflas/fflas.h:104, from ../../../../../../../../include/fflasffpack/ffpack/ffpack.h:47, from ../../linbox/matrix/matrixdomain/blasmatrixdomain.h:45, from ../../linbox/matrix/matrixdomain.h:68, from ../../linbox/matrix/transposematrix.h:47, from ../../linbox/matrix/matrixdomain/matrixdomain.inl:34, from ../../linbox/matrix/matrixdomain/matrixdomain.h:1233, from ../../linbox/matrix/densematrix/blasmatrix.h:55, from ../../linbox/matrix/densematrix.h:79, from ../../linbox/algorithms/rationalsolver.h:43, from ../../linbox/algorithms/diophantinesolver.h:29, from diophantinesolver.C:26: ../../../../../../../../include/fflasffpack/fflas/fflas_simd/simd256_int16.inl:258:92: warning: 'const' attribute on function returning 'void' [Wattributes] static INLINE CONST void unpacklohi(vect_t& s1, vect_t& s2, const vect_t a, const vect_t b) {
Change History (11)
comment:1 Changed 3 years ago by
comment:2 Changed 3 years ago by
 Summary changed from linbox fail to build with gcc 8.1.0 to fflas and linbox broken with gcc 8.1.0
comment:3 Changed 3 years ago by
See a discussion and a patch at https://groups.google.com/forum/#!topic/sagedevel/NgzlZknrizg
comment:4 Changed 3 years ago by
 Branch set to u/cpernet/fflas_and_linbox_broken_with_gcc_8_1_0
comment:5 Changed 3 years ago by
 Branch u/cpernet/fflas_and_linbox_broken_with_gcc_8_1_0 deleted
I agree with the proposed fixes for fflas given here and the simple removal of the double template proposed on sagedevel by fidelbc and Dario Asprone. I have fixed both libraries upstream and add the corresponding patches to the branch for this ticket.
comment:6 Changed 3 years ago by
 Branch set to u/cpernet/fflas_and_linbox_broken_with_gcc_8_1_0
comment:7 Changed 3 years ago by
 Cc slelievre added
 Commit set to cb566ea35dc8e494ca3a8f0720b0a7f76c1386c1
 Keywords fflas linbox gcc8 added
Don't forget to set to "needs review" if this is ready for review.
New commits:
cb566ea  fixing gcc8.1 compilation errors.

comment:8 Changed 3 years ago by
 Status changed from new to needs_review
comment:9 Changed 3 years ago by
 Report Upstream changed from N/A to Fixed upstream, but not in a stable release.
comment:10 Changed 3 years ago by
 Reviewers set to Julian Rüth
 Status changed from needs_review to positive_review
comment:11 Changed 3 years ago by
 Branch changed from u/cpernet/fflas_and_linbox_broken_with_gcc_8_1_0 to cb566ea35dc8e494ca3a8f0720b0a7f76c1386c1
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Solve the
const void
in fflas with