Opened 4 years ago

Closed 4 years ago

#25335 closed defect (fixed)

Missing imports in src/sage/geometry/polyhedron/base.py

Reported by: jdemeyer Owned by:
Priority: blocker Milestone: sage-8.3
Component: interfaces: optional Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton, Dima Pasechnik Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: a9aa389 (Commits, GitHub, GitLab) Commit: a9aa389e3663cd0165471202e004c4aa5a732ed6
Dependencies: Stopgaps:

Status badges

Description

Fix the missing imports reported at #25332.

Change History (4)

comment:1 Changed 4 years ago by dimpase

this

diff --git a/src/sage/geometry/polyhedron/base.py b/src/sage/geometry/polyhedron/base.py
index 2158912474..5cd789b733 100644
--- a/src/sage/geometry/polyhedron/base.py
+++ b/src/sage/geometry/polyhedron/base.py
@@ -4343,6 +4343,7 @@ class Polyhedron_base(Element):
 
              David Avis's lrs program.
         """
+        from sage.features.lrs import Lrs
         Lrs().require()
 
         from sage.misc.temporary_file import tmp_filename

suffices to fix this

comment:2 Changed 4 years ago by chapoton

  • Authors set to Frédéric Chapoton, Dima Pasechnik
  • Branch set to public/25335
  • Commit set to a9aa389e3663cd0165471202e004c4aa5a732ed6
  • Status changed from new to needs_review

New commits:

a9aa389fix features import in lrs

comment:3 Changed 4 years ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

Looks good to me, thanks.

comment:4 Changed 4 years ago by vbraun

  • Branch changed from public/25335 to a9aa389e3663cd0165471202e004c4aa5a732ed6
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.