Opened 4 years ago

Closed 4 years ago

#25325 closed defect (fixed)

Feature check for benzene is broken

Reported by: gh-antonio-rojas Owned by:
Priority: blocker Milestone: sage-8.3
Component: packages: optional Keywords:
Cc: fbissey Merged in:
Authors: Vincent Delecroix Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 8b0adb8 (Commits, GitHub, GitLab) Commit: 8b0adb8f00e64dae02112d267ab26745cdd65942
Dependencies: Stopgaps:

Status badges

Description

There is a mistake in the Benzene Features test: it should test for the ">>planar_code<<" string, not for ">>planar_graph<<". As it is now, the test always fails.

Change History (9)

comment:1 Changed 4 years ago by gh-antonio-rojas

Last edited 4 years ago by jdemeyer (previous) (diff)

comment:2 Changed 4 years ago by gh-antonio-rojas

Last edited 4 years ago by jdemeyer (previous) (diff)

comment:3 Changed 4 years ago by gh-antonio-rojas

  • Summary changed from Typo in benzene Features check to Several issues with Features

comment:4 Changed 4 years ago by fbissey

  • Cc fbissey added

comment:5 Changed 4 years ago by jdemeyer

  • Priority changed from minor to blocker
  • Summary changed from Several issues with Features to Feature check for benzene is broken

comment:6 Changed 4 years ago by jdemeyer

I created #25334 for CSDP and #25333 for plantri.

comment:7 Changed 4 years ago by vdelecroix

  • Authors set to Vincent Delecroix
  • Branch set to u/vdelecroix/25325
  • Commit set to 8b0adb8f00e64dae02112d267ab26745cdd65942
  • Status changed from new to needs_review

New commits:

​8b0adb825325: fix benzene feature

comment:8 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:9 Changed 4 years ago by vbraun

  • Branch changed from u/vdelecroix/25325 to 8b0adb8f00e64dae02112d267ab26745cdd65942
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.