Opened 3 years ago
Closed 3 years ago
#25323 closed defect (fixed)
Feature check for GAP package "prim" is wrong
Reported by: | charpent | Owned by: | |
---|---|---|---|
Priority: | blocker | Milestone: | sage-8.3 |
Component: | packages: optional | Keywords: | |
Cc: | fbissey, chapoton | Merged in: | |
Authors: | Dima Pasechnik | Reviewers: | John Palmieri |
Report Upstream: | N/A | Work issues: | |
Branch: | 77c1a2e (Commits, GitHub, GitLab) | Commit: | 77c1a2e899a816e4c89979baf3ddccebc9b0ea9f |
Dependencies: | Stopgaps: |
Description (last modified by )
Seen first in 8.3.beta0 ; see the relevant announcement in sage_release.
There is in fact no such GAP package in GAP 4.8. However, it is a part of optional Sage package database_gap
Change History (13)
comment:1 follow-up: ↓ 3 Changed 3 years ago by
comment:2 Changed 3 years ago by
- Priority changed from major to blocker
comment:3 in reply to: ↑ 1 Changed 3 years ago by
Replying to jdemeyer:
Important questions: is the package truly missing or is the check for the package broken? And is the package required in the first place to do that computation?
Thé package is *NOT* missing. And this happens even after a forced reinstallation sage -f database_gap
.
comment:4 Changed 3 years ago by
I've never heard of such a package, see also https://www.gap-system.org/Packages/packages.html
a typo?
comment:5 Changed 3 years ago by
There is no such GAP package in GAP 4.8
There will be primgrp package (https://github.com/gap-packages/primgrp) in GAP 4.9.
comment:6 Changed 3 years ago by
- Description modified (diff)
- Summary changed from The "prim" package of database_gap appears to be missing to Feature check for GAP package "prim" is wrong
comment:7 Changed 3 years ago by
- Description modified (diff)
comment:8 Changed 3 years ago by
- Cc fbissey added
comment:9 Changed 3 years ago by
OK, this needs the same treatment as Small Groups library in sage/features/gap.py
.
I'll provide a fix.
comment:10 Changed 3 years ago by
- Branch set to u/dimpase/gap/prim_like_small
- Cc chapoton added
- Commit set to 77c1a2e899a816e4c89979baf3ddccebc9b0ea9f
- Status changed from new to needs_review
New commits:
77c1a2e | treat primitive groups in GAP in the same way as small groups
|
comment:11 Changed 3 years ago by
Note that TransitiveGroup
needs the same treatment (being part of database_gap)
comment:12 Changed 3 years ago by
- Reviewers set to John Palmieri
- Status changed from needs_review to positive_review
Looks good to me.
comment:13 Changed 3 years ago by
- Branch changed from u/dimpase/gap/prim_like_small to 77c1a2e899a816e4c89979baf3ddccebc9b0ea9f
- Resolution set to fixed
- Status changed from positive_review to closed
Important questions: is the package truly missing or is the check for the package broken? And is the package required in the first place to do that computation?