Opened 3 years ago
Closed 8 weeks ago
#25322 closed enhancement (fixed)
Some cleanup of the libsingular polynomial constructor
Reported by:  mmezzarobba  Owned by:  

Priority:  major  Milestone:  sage9.3 
Component:  commutative algebra  Keywords:  
Cc:  Merged in:  
Authors:  Marc Mezzarobba  Reviewers:  Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  9c88b5b (Commits, GitHub, GitLab)  Commit:  9c88b5b988ca8494a73e937c181bcd1500716663 
Dependencies:  Stopgaps: 
Description
Change History (6)
comment:1 Changed 3 years ago by
comment:2 Changed 3 years ago by
 Milestone changed from sage8.3 to sage8.4
update milestone 8.3 > 8.4
comment:3 Changed 8 months ago by
 Branch set to u/mmezzarobba/mpoly_singular_constructor
 Commit set to 9c88b5b988ca8494a73e937c181bcd1500716663
 Milestone changed from sage8.4 to sage9.3
 Status changed from new to needs_review
 Summary changed from Some cleanup of the libsingular polynomial constructor and related methods to Some cleanup of the libsingular polynomial constructor
Hmm, I suppose I must have forgotten to push the branch back then. That's just a first step; this code needs more love...
New commits:
d07c96a  #25322 Singular poly constructor: reorder some blocks

28b4502  #25322 Singular poly constructori: remove redundancies...

9c88b5b  #25322 Singular poly constructor: further minor improvements

comment:4 Changed 3 months ago by
 Reviewers set to Frédéric Chapoton
 Status changed from needs_review to positive_review
ok, let's do that as a first step
comment:5 Changed 3 months ago by
thank you!
comment:6 Changed 8 weeks ago by
 Branch changed from u/mmezzarobba/mpoly_singular_constructor to 9c88b5b988ca8494a73e937c181bcd1500716663
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
so what ?