Opened 3 years ago

Closed 8 weeks ago

#25322 closed enhancement (fixed)

Some cleanup of the libsingular polynomial constructor

Reported by: mmezzarobba Owned by:
Priority: major Milestone: sage-9.3
Component: commutative algebra Keywords:
Cc: Merged in:
Authors: Marc Mezzarobba Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 9c88b5b (Commits, GitHub, GitLab) Commit: 9c88b5b988ca8494a73e937c181bcd1500716663
Dependencies: Stopgaps:

Status badges

Description


Change History (6)

comment:1 Changed 3 years ago by chapoton

so what ?

comment:2 Changed 3 years ago by vdelecroix

  • Milestone changed from sage-8.3 to sage-8.4

update milestone 8.3 -> 8.4

comment:3 Changed 8 months ago by mmezzarobba

  • Branch set to u/mmezzarobba/mpoly_singular_constructor
  • Commit set to 9c88b5b988ca8494a73e937c181bcd1500716663
  • Milestone changed from sage-8.4 to sage-9.3
  • Status changed from new to needs_review
  • Summary changed from Some cleanup of the libsingular polynomial constructor and related methods to Some cleanup of the libsingular polynomial constructor

Hmm, I suppose I must have forgotten to push the branch back then. That's just a first step; this code needs more love...

New commits:

​d07c96a#25322 Singular poly constructor: reorder some blocks
​28b4502#25322 Singular poly constructori: remove redundancies...
​9c88b5b#25322 Singular poly constructor: further minor improvements
Last edited 8 months ago by mmezzarobba (previous) (diff)

comment:4 Changed 3 months ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, let's do that as a first step

comment:5 Changed 3 months ago by mmezzarobba

thank you!

comment:6 Changed 8 weeks ago by vbraun

  • Branch changed from u/mmezzarobba/mpoly_singular_constructor to 9c88b5b988ca8494a73e937c181bcd1500716663
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.