Opened 15 years ago

Closed 15 years ago

#2532 closed defect (fixed)

[with patch, positive review] padic bugfix

Reported by: David Roe Owned by: David Roe
Priority: major Milestone: sage-2.10.4
Component: basic arithmetic Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Michael Abshoff)

Fixes a number of bugs in p-adic extensions.

  • changes many object creation functions to pass on exceptions if necessary.
  • fixes a bug in precision_absolute for capped relative extension elements that causes it to return the wrong answer if the element is not normalized.
  • Fixes object creation functions so that they do not fail when asked to create an element of precision zero.

Attachments (1)

padic_restore_context_zero_bugfix.patch (37.3 KB) - added by David Roe 15 years ago.

Download all attachments as: .zip

Change History (8)

Changed 15 years ago by David Roe

comment:1 Changed 15 years ago by Mike Hansen

Summary: [with-patch] padic bugfix[with patch, needs review] padic bugfix

comment:2 Changed 15 years ago by Michael Abshoff

Description: modified (diff)

comment:3 Changed 15 years ago by Mike Hansen

Summary: [with patch, needs review] padic bugfix[with patch, positive review pending changes] padic bugfix

The patch applies, builds, and passes all tests. However, a follow-up patch should be added which adds doctests to show that the bugs are indeed fixed.

comment:4 Changed 15 years ago by Michael Abshoff

Milestone: sage-2.11sage-2.10.4

Doctests also pass for me when applying the patch to 2.10.4.final. After talking to roed about the missing doctest in IRC yesterday I tend to want to merge this and hope that doctests are forthcomings since these fixes have been tested and reviewed by several people "back east."

Cheers,

Michael

comment:5 Changed 15 years ago by David Harvey

I agree. Given the current doctest coverage and code complexity of the p-adics code, I think we should just merge this and wait for the real doctesting work to catch up.

comment:6 Changed 15 years ago by Michael Abshoff

Summary: [with patch, positive review pending changes] padic bugfix[with patch, positive review] padic bugfix

I agree with dmharvey. #610 covers the need to increase doctest coverage. Maybe somebody else besides roed can help out here?

Cheers,

Michael

comment:7 Changed 15 years ago by Michael Abshoff

Resolution: fixed
Status: newclosed

Merged in Sage 2.10.4.final - note that the patch is a GNU patch. I did commit it in roed's name.

Note: See TracTickets for help on using tickets.