Opened 23 months ago

Closed 22 months ago

Last modified 22 months ago

#25319 closed defect (fixed)

gcc, curl, git tarballs not included by sage --sdist

Reported by: jhpalmieri Owned by:
Priority: blocker Milestone: sage-8.3
Component: build Keywords:
Cc: vbraun, embray Merged in:
Authors: Jeroen Demeyer Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: a6add27 (Commits) Commit:
Dependencies: Stopgaps:

Description

It seems that packages that are not built on a system because of a configure check are not included in the upstream directory when running sage --sdist. This will often include gcc, curl, git, gfortran (which is the same tarball as gcc).

Change History (12)

comment:1 follow-up: Changed 23 months ago by vbraun

Related, it would be nice if sage -sdist wouldn't rely on configure at all. Right now, sdist basically requires you to configure / build Sage before making a tarball which is an annoyance for release management. As we see on this ticket, it is also error prone.

comment:2 Changed 22 months ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Cc embray added

It's this change from #21524:

@@ -58,11 +58,11 @@ all-sage: \
 # option to make forces all targets to be built unconditionally)
 download-for-sdist: base
        env SAGE_INSTALL_FETCH_ONLY=yes $(MAKE) -B SAGERUNTIME= \
-               $(SDIST_PACKAGES)
+               $(SDIST_PACKAGE_INSTS)
 

Just reverting that should fix the problem.

comment:3 Changed 22 months ago by jdemeyer

  • Branch set to u/jdemeyer/gcc__curl__git_tarballs_not_included_by_sage___sdist

comment:4 Changed 22 months ago by git

  • Commit set to a6add271efcba7a31de354ce50632c2bb265aa59

Branch pushed to git repo; I updated commit sha1. New commits:

a6add27Drop "base" dependency of download-for-sdist

comment:5 Changed 22 months ago by jdemeyer

  • Status changed from new to needs_review

comment:6 in reply to: ↑ 1 ; follow-up: Changed 22 months ago by jdemeyer

Replying to vbraun:

Related, it would be nice if sage -sdist wouldn't rely on configure at all.

Seriously, what is wrong with requiring ./configure? Every autotools package depends on ./configure before you can do anything. It only takes a few seconds...

Right now, sdist basically requires you to configure / build Sage before making a tarball

configuring yes, but not building!

I just did

make distclean && ./configure && ./sage --sdist

and it worked.

comment:7 Changed 22 months ago by jhpalmieri

I am happy to give this a positive review, but maybe first someone (embray?) should explain the purpose of the change from #21524 that we are reverting.

comment:8 Changed 22 months ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

Okay, let's move on.

comment:9 Changed 22 months ago by vbraun

  • Branch changed from u/jdemeyer/gcc__curl__git_tarballs_not_included_by_sage___sdist to a6add271efcba7a31de354ce50632c2bb265aa59
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:10 in reply to: ↑ 6 ; follow-up: Changed 22 months ago by embray

  • Commit a6add271efcba7a31de354ce50632c2bb265aa59 deleted

Replying to jdemeyer:

Replying to vbraun:

Related, it would be nice if sage -sdist wouldn't rely on configure at all.

Seriously, what is wrong with requiring ./configure? Every autotools package depends on ./configure before you can do anything. It only takes a few seconds...

I agree with Jeroen :)

Right now, sdist basically requires you to configure / build Sage before making a tarball

configuring yes, but not building!

I just did

make distclean && ./configure && ./sage --sdist

and it worked.

+1

I didn't even know what sage --sdist is supposed to do though. Is that documented somewhere?

comment:11 in reply to: ↑ 10 Changed 22 months ago by jhpalmieri

Replying to embray:

I didn't even know what sage --sdist is supposed to do though. Is that documented somewhere?

The description of command-line options available from sage --advanced (and also in the reference manual) says

  -sdist              -- build a source distribution of Sage

That's the extent of the documentation, I think.

comment:12 Changed 22 months ago by embray

It's not really clear what's meant by that.

Note: See TracTickets for help on using tickets.