Opened 4 years ago

Closed 4 years ago

#25306 closed enhancement (fixed)

some care for magma interface

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.3
Component: interfaces Keywords: magma
Cc: davidloeffler Merged in:
Authors: Frédéric Chapoton Reviewers: David Loeffler
Report Upstream: N/A Work issues:
Branch: ba69135 (Commits, GitHub, GitLab) Commit: ba69135f8b0aca8db811fd59c7b6a9073db72b0a
Dependencies: Stopgaps:

Status badges

Description

because parts of it are broken for magma V2.22

and also enhance its treatment of matrices.

Change History (14)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/25306
  • Commit set to 5e52902bd608ac4a6ff8572ecfb5635b9afa39a0

New commits:

​5e52902trying to fix magma interface, and enhance it for matrices

comment:2 Changed 4 years ago by chapoton

  • Keywords magma added

comment:3 Changed 4 years ago by chapoton

  • Status changed from new to needs_review

comment:4 Changed 4 years ago by chapoton

  • Cc davidloeffler added

comment:5 Changed 4 years ago by davidloeffler

  • Status changed from needs_review to needs_work

I tested it against Magma v2.23-8 but many doctests failed. I have opened #25408 for this issue, where there are 12 failures listed; 8 of them still fail with this patch installed.

comment:6 Changed 4 years ago by git

  • Commit changed from 5e52902bd608ac4a6ff8572ecfb5635b9afa39a0 to 950d3250e0f3ee60666e8a5bbe1d1e62fdf3ba3d

Branch pushed to git repo; I updated commit sha1. New commits:

​bdf0508Merge branch 'u/chapoton/25306 in 8.3.b2
​950d325fix one doctest (change of point found on conic)

comment:7 Changed 4 years ago by chapoton

Could we agree to use this as a first step ? I would like to have the matrix enhancements at my disposal.

comment:8 Changed 4 years ago by davidloeffler

  • Branch changed from u/chapoton/25306 to u/davidloeffler/25306

comment:9 Changed 4 years ago by davidloeffler

  • Commit changed from 950d3250e0f3ee60666e8a5bbe1d1e62fdf3ba3d to 9b42b5a056bfe58b182430749ffe46a1a6b9a918

OK, I see your point. The perfect is the enemy of the good, as the saying goes. I pushed a patch which fixes a couple more doctests that were failing (no code changes) -- if you're happy with that then please set the ticket to positive review.

New commits:

​9b42b5aFix a couple more failing doctests

comment:10 Changed 4 years ago by chapoton

  • Reviewers set to David Loeffler
  • Status changed from needs_work to positive_review

thanks. good for me. Note that the Kronecker representation seems to have changed betwen my version of m*gma and yours..

comment:11 Changed 4 years ago by vbraun

  • Status changed from positive_review to needs_work 
sage -t --long src/sage/interfaces/magma.py
**********************************************************************
File "src/sage/interfaces/magma.py", line 2088, in sage.interfaces.magma.MagmaElement.AssignNames
Failed example:
    S.1^2 + S.2
Exception raised:
    Traceback (most recent call last):
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 572, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 982, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.interfaces.magma.MagmaElement.AssignNames[0]>", line 1, in <module>
        S.gen(1)**Integer(2) + S.gen(2)
    NameError: name 'S' is not defined
**********************************************************************
1 item had failures:
   1 of   2 in sage.interfaces.magma.MagmaElement.AssignNames
    [84 tests, 1 failure, 0.77 s]

comment:12 Changed 4 years ago by git

  • Commit changed from 9b42b5a056bfe58b182430749ffe46a1a6b9a918 to ba69135f8b0aca8db811fd59c7b6a9073db72b0a

Branch pushed to git repo; I updated commit sha1. New commits:

​ba69135Trac #25306: missing #optional flag on doctest

comment:13 Changed 4 years ago by davidloeffler

  • Status changed from needs_work to positive_review

Oops, I forgot to flag this doctest as #optional-magma.

Last edited 4 years ago by davidloeffler (previous) (diff)

comment:14 Changed 4 years ago by vbraun

  • Branch changed from u/davidloeffler/25306 to ba69135f8b0aca8db811fd59c7b6a9073db72b0a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.