Opened 10 months ago

Closed 9 months ago

#25303 closed enhancement (fixed)

Random orientation of a graph

Reported by: dcoudert Owned by:
Priority: minor Milestone: sage-8.3
Component: graph theory Keywords:
Cc: dcoudert, slabbe, slelievre Merged in:
Authors: David Coudert Reviewers: Sébastien Labbé
Report Upstream: N/A Work issues:
Branch: f653d27 (Commits) Commit: f653d2743ddec173c9685afacbfea8cd6152d6f9
Dependencies: Stopgaps:

Description

This patch implements a simple method to get a random orientation of a graph, uniformly at random.

It follows discussion ​https://ask.sagemath.org/question/42274/random-orientation-of-a-graph/.

Change History (10)

comment:1 Changed 10 months ago by dcoudert

  • Branch set to u/dcoudert/25303_random_orientation
  • Cc slelievre added
  • Commit set to 8e5d77bb69f45d1c44c7e16448fa7da41250630b
  • Status changed from new to needs_review

I think it's a useful method.

New commits:

​8e5d77btrac #25303: random orientation of graphs

comment:2 Changed 10 months ago by slabbe

  • Reviewers set to Sébastien Labbé
  • Status changed from needs_review to positive_review

comment:3 Changed 10 months ago by dcoudert

Thanks for the review.

comment:4 Changed 9 months ago by dcoudert

Actually, shouldn't we place this method into module orientations.py instead of graph.py?

comment:5 Changed 9 months ago by slelievre

  • Cc dcoudert slabbe added
  • Status changed from positive_review to needs_work

Putting this in orientations.py would indeed make sense.

comment:6 Changed 9 months ago by git

  • Commit changed from 8e5d77bb69f45d1c44c7e16448fa7da41250630b to f653d2743ddec173c9685afacbfea8cd6152d6f9

Branch pushed to git repo; I updated commit sha1. New commits:

​87a2403trac #25303: Merged with 8.3.beta0
​f653d27trac #25303: move the method to orientations.py

comment:7 Changed 9 months ago by dcoudert

  • Status changed from needs_work to needs_review

ready for review.

comment:8 Changed 9 months ago by slabbe

  • Status changed from needs_review to positive_review

comment:9 Changed 9 months ago by dcoudert

Thanks.

comment:10 Changed 9 months ago by vbraun

  • Branch changed from u/dcoudert/25303_random_orientation to f653d2743ddec173c9685afacbfea8cd6152d6f9
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.