Opened 3 years ago

Closed 3 years ago

#25283 closed enhancement (fixed)

Implement left descent and reduced word for colored permutations

Reported by: tscrim Owned by:
Priority: major Milestone: sage-8.3
Component: combinatorics Keywords: colored permutations, complex reflection groups
Cc: sage-combinat, andrew.mathas, stumpc5, chapoton Merged in:
Authors: Travis Scrimshaw Reviewers: Andrew Mathas
Report Upstream: N/A Work issues:
Branch: f9cca1a (Commits, GitHub, GitLab) Commit: f9cca1a180b71d4ec94b16fc53f596897d180340
Dependencies: Stopgaps:

Status badges

Description

Because they are nice enough groups, we can define an algorithm using left descents (in a certain sense) to compute a reduced word for a colored permutation using the standard generating set.

Change History (9)

comment:1 Changed 3 years ago by tscrim

  • Branch set to public/combinat/colored_permutations_reduced_word-25283
  • Commit set to 39c0121fbeddb7ba5cbea421b3e4fa62683463ae
  • Status changed from new to needs_review

New commits:

39c0121Implementation of descents and reduced word for colored permutations.

comment:2 Changed 3 years ago by chapoton

coverage is not 100%

comment:3 Changed 3 years ago by git

  • Commit changed from 39c0121fbeddb7ba5cbea421b3e4fa62683463ae to 55d7f221cbd3e9435ada34ab3eaf42deda0ca804

Branch pushed to git repo; I updated commit sha1. New commits:

55d7f22Adding missing doctest.

comment:4 Changed 3 years ago by tscrim

Forgot to add that doctest in. Now at 100% coverage.

comment:5 Changed 3 years ago by andrew.mathas

  • Reviewers set to Andrew Mathas
  • Status changed from needs_review to positive_review

A nice small patch that's easy to review:) I haven't checked the mathematics but the doc tests do this so I think it's good to go.

Last edited 3 years ago by andrew.mathas (previous) (diff)

comment:6 Changed 3 years ago by vbraun

  • Status changed from positive_review to needs_work

Merge conflict

comment:7 Changed 3 years ago by git

  • Commit changed from 55d7f221cbd3e9435ada34ab3eaf42deda0ca804 to f9cca1a180b71d4ec94b16fc53f596897d180340

Branch pushed to git repo; I updated commit sha1. New commits:

f9cca1aMerge branch 'public/combinat/colored_permutations_reduced_word-25283' of git://trac.sagemath.org/sage into public/combinat/colored_permutations_reduced_word-25283

comment:8 Changed 3 years ago by tscrim

  • Status changed from needs_work to positive_review

Trivial conflict.

comment:9 Changed 3 years ago by vbraun

  • Branch changed from public/combinat/colored_permutations_reduced_word-25283 to f9cca1a180b71d4ec94b16fc53f596897d180340
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.