Opened 3 years ago

Closed 3 years ago

#25275 closed enhancement (fixed)

Function to get input and output size of an SBox

Reported by: ruhm Owned by:
Priority: minor Milestone: sage-8.3
Component: cryptography Keywords: days94
Cc: Merged in:
Authors: Rusydi H. Makarim Reviewers: Friedrich Wiemer
Report Upstream: N/A Work issues:
Branch: 3aa99a3 (Commits, GitHub, GitLab) Commit: 3aa99a373deb5e0590e53bdd114191b5bb3e40f2
Dependencies: Stopgaps:

Status badges

Description (last modified by ruhm)

The input and output size of SBox are stored in self.m and self.n respectively. To improve readability, this ticket implements self.input_size() and self.output_size(). Other parts of SBox module are also modified to reflect these changes.

Change History (10)

comment:1 Changed 3 years ago by ruhm

  • Authors set to Rusydi H. Makarim
  • Component changed from PLEASE CHANGE to cryptography
  • Description modified (diff)
  • Priority changed from major to minor
  • Type changed from PLEASE CHANGE to enhancement

comment:2 Changed 3 years ago by ruhm

  • Branch set to u/ruhm/sbox_input_output

comment:3 Changed 3 years ago by ruhm

  • Commit set to a3eb152a7c7fecdd3c4609d985dd7d696c3ccec6
  • Status changed from new to needs_review

New commits:

a3eb152initial commit for input_size() and output_size()

comment:4 Changed 3 years ago by asante

There are currently merge conflicts.

comment:5 Changed 3 years ago by asante

  • Status changed from needs_review to needs_work

comment:6 Changed 3 years ago by asante

  • Keywords days94 added

comment:7 Changed 3 years ago by git

  • Commit changed from a3eb152a7c7fecdd3c4609d985dd7d696c3ccec6 to 3aa99a373deb5e0590e53bdd114191b5bb3e40f2

Branch pushed to git repo; I updated commit sha1. New commits:

3aa99a3Merge branch 'develop' into t/25275/sbox_input_output

comment:8 Changed 3 years ago by ruhm

  • Status changed from needs_work to needs_review

comment:9 Changed 3 years ago by asante

  • Reviewers set to Friedrich Wiemer
  • Status changed from needs_review to positive_review

LGTM

comment:10 Changed 3 years ago by vbraun

  • Branch changed from u/ruhm/sbox_input_output to 3aa99a373deb5e0590e53bdd114191b5bb3e40f2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.