Opened 3 years ago

Closed 3 years ago

#25274 closed enhancement (fixed)

Clean up cimports in libgap

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.3
Component: interfaces Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 0b4ad78 (Commits, GitHub, GitLab) Commit: 0b4ad78c6194a0a38e2e9aa036de584b03d0dc35
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

Remove stuff from src/sage/libs/gap/*.pxd files which are not meant to be exported.

This is mainly meant as preparation for #25273.

Change History (7)

comment:1 Changed 3 years ago by jdemeyer

  • Branch set to u/jdemeyer/minimize_src_sage_libs_gap_util_pxd

comment:2 Changed 3 years ago by jdemeyer

  • Commit set to b8c3c12a65c71f4612577f8bd7c29d0825bfe18a
  • Description modified (diff)
  • Status changed from new to needs_review
  • Summary changed from Minimize src/sage/libs/gap/util.pxd to Clean up cimports in libgap

New commits:

​b8c3c12Clean up cimports in libgap

comment:3 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 3 years ago by vbraun

  • Status changed from positive_review to needs_work

Merge conflict

comment:5 Changed 3 years ago by git

  • Commit changed from b8c3c12a65c71f4612577f8bd7c29d0825bfe18a to 0b4ad78c6194a0a38e2e9aa036de584b03d0dc35

Branch pushed to git repo; I updated commit sha1. New commits:

​0b4ad78Merge tag '8.3.beta1' into t/25274/minimize_src_sage_libs_gap_util_pxd

comment:6 Changed 3 years ago by jdemeyer

  • Status changed from needs_work to positive_review

comment:7 Changed 3 years ago by vbraun

  • Branch changed from u/jdemeyer/minimize_src_sage_libs_gap_util_pxd to 0b4ad78c6194a0a38e2e9aa036de584b03d0dc35
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.