Opened 3 years ago

Last modified 3 years ago

#25273 closed enhancement

Unprefixed libGAP interface — at Version 13

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: interfaces Keywords:
Cc: slelievre Merged in:
Authors: Jeroen Demeyer Reviewers:
Report Upstream: N/A Work issues:
Branch: u/jdemeyer/unprefixed_libgap_interface (Commits, GitHub, GitLab) Commit: d28b5757ad45cd54ae70adf25c72fcefef8b1a01
Dependencies: #25274 Stopgaps:

Status badges

Description (last modified by slelievre)

Use Cython cname declarations to use unprefixed libGAP names in Sage. The libGAP package is not changed at all, only the Sage interface.

Obvious exceptions:

  • libGAP_True
  • libGAP_False

Change History (13)

comment:1 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:3 Changed 3 years ago by jdemeyer

  • Dependencies set to #25274

comment:4 Changed 3 years ago by dimpase

  • Dependencies #25274 deleted

Does this mean that libgap.Blah syntax won't be needed, too?

comment:5 Changed 3 years ago by dimpase

  • Dependencies set to #25274

comment:6 Changed 3 years ago by jdemeyer

  • Branch set to u/jdemeyer/unprefixed_libgap_interface

comment:7 Changed 3 years ago by jdemeyer

  • Commit set to ea2e39c7374b03b97366f264c89a0f4c75a7c172
  • Status changed from new to needs_review

New commits:

b8c3c12Clean up cimports in libgap
ea2e39cUnprefixed libGAP interface

comment:8 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:9 Changed 3 years ago by dimpase

  • Description modified (diff)

In libgap.pyx you have

The ``foobar`` methods are
the original GAP methods simply prefixed with the string
````.

which looks like an artefact of non-interactive editing...

I presume there is no prefix any more.

comment:10 Changed 3 years ago by git

  • Commit changed from ea2e39c7374b03b97366f264c89a0f4c75a7c172 to 72b5066bb6b1606bef5d7e88c1a8d5fab62b5192

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

72b5066Unprefixed libGAP interface

comment:11 Changed 3 years ago by git

  • Commit changed from 72b5066bb6b1606bef5d7e88c1a8d5fab62b5192 to d28b5757ad45cd54ae70adf25c72fcefef8b1a01

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d28b575Unprefixed libGAP interface

comment:12 Changed 3 years ago by dimpase

The only libGAP_ things left are libGAP_True/False. There are also libgap_-things, but this is another story. The docs about libGAP_ ought to be more explicit about this.

comment:13 Changed 3 years ago by slelievre

  • Cc slelievre added
  • Description modified (diff)
Note: See TracTickets for help on using tickets.