Opened 3 years ago

Closed 3 years ago

#25272 closed enhancement (fixed)

LatticePoset: Add test for 25244 and 25266

Reported by: jmantysalo Owned by:
Priority: minor Milestone: sage-8.3
Component: combinatorics Keywords:
Cc: Merged in:
Authors: Jori Mäntysalo Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 044913d (Commits, GitHub, GitLab) Commit: 044913d5d7552badf6467a872ac666fc86f06a4b
Dependencies: Stopgaps:

Status badges

Description

This ticket adds functions from #25244 and #25266 to the test set. Makes of course sense only after they have been merged to beta.

Change History (7)

comment:1 Changed 3 years ago by jmantysalo

  • Branch set to u/jmantysalo/lattice-test

comment:2 Changed 3 years ago by git

  • Commit set to 5432da3e0b51d494714b6d46ad4df8b152af8399

Branch pushed to git repo; I updated commit sha1. New commits:

5432da3Self-dual properties.

comment:3 Changed 3 years ago by git

  • Commit changed from 5432da3e0b51d494714b6d46ad4df8b152af8399 to 044913d5d7552badf6467a872ac666fc86f06a4b

Branch pushed to git repo; I updated commit sha1. New commits:

044913dMerge branch 'develop' into t/25272/lattice-test

comment:4 follow-up: Changed 3 years ago by tscrim

They can just be simple dependencies...

comment:5 in reply to: ↑ 4 Changed 3 years ago by jmantysalo

  • Status changed from new to needs_review

Replying to tscrim:

They can just be simple dependencies...

Would have been easier, true.

comment:6 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:7 Changed 3 years ago by vbraun

  • Branch changed from u/jmantysalo/lattice-test to 044913d5d7552badf6467a872ac666fc86f06a4b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.