Opened 3 years ago

Closed 3 years ago

#25266 closed enhancement (fixed)

LatticePoset: Add is_sublattice_dismantlable

Reported by: jmantysalo Owned by:
Priority: major Milestone: sage-8.3
Component: combinatorics Keywords:
Cc: chapoton Merged in:
Authors: Jori Mäntysalo Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: e60b367 (Commits, GitHub, GitLab) Commit: e60b36785a28fa357e68b461057872cf040c973a
Dependencies: #25244 Stopgaps:

Status badges

Description

At the end of https://link.springer.com/content/pdf/10.1007%2Fs11083-017-9422-7.pdf there is a definition of "sublattice dismantlable" lattices with a question of characterizing those.

This patch adds the function that recognized those lattices.

Requires #25244 because of crosslinks. Contains a non-related change to posets.py.

Change History (10)

comment:1 Changed 3 years ago by jmantysalo

  • Branch set to u/jmantysalo/sublattice-dismantlable

comment:2 Changed 3 years ago by jmantysalo

  • Commit set to af39c198d872f3da3000a5bf35cbfcef3c45a723
  • Status changed from new to needs_review

Hopefully I got the dependency right.


New commits:

e62e8b6Add is_interval_dismantlable.
940ee02Two corrections.
aa09754Correct doc.
b064055Raise (again) limit for gen_rest_table_index.
af39c19Add is_sublattice_dismantlable.

comment:3 Changed 3 years ago by git

  • Commit changed from af39c198d872f3da3000a5bf35cbfcef3c45a723 to 245a8d7750fe52b59d2e1ad5d166dc0ffdd5c016

Branch pushed to git repo; I updated commit sha1. New commits:

9bfd162Merge branch 'develop' into t/25266/sublattice-dismantlable
245a8d7Docstring formatting error.

comment:4 Changed 3 years ago by jmantysalo

Now with an additional colon, should work now.

comment:5 Changed 3 years ago by jmantysalo

Just pinging. Should be quite straightforward.

comment:6 Changed 3 years ago by chapoton

I would say into instead of to

subdivision of a lattice to two non-empty

typos:

distmantlings
interval-dismantlabe

comment:7 Changed 3 years ago by git

  • Commit changed from 245a8d7750fe52b59d2e1ad5d166dc0ffdd5c016 to e60b36785a28fa357e68b461057872cf040c973a

Branch pushed to git repo; I updated commit sha1. New commits:

e60b367Typo corrections.

comment:8 Changed 3 years ago by jmantysalo

Good point & true, corrected those.

comment:9 Changed 3 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok.

comment:10 Changed 3 years ago by vbraun

  • Branch changed from u/jmantysalo/sublattice-dismantlable to e60b36785a28fa357e68b461057872cf040c973a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.