Opened 4 years ago

Closed 4 years ago

#25248 closed defect (fixed)

py3: fix sage.parallel.map_reduce

Reported by: embray Owned by:
Priority: major Milestone: sage-8.3
Component: python3 Keywords:
Cc: hivert Merged in:
Authors: Erik Bray Reviewers: Florent Hivert
Report Upstream: N/A Work issues:
Branch: 8f3f013 (Commits, GitHub, GitLab) Commit: 8f3f013e4e3303954750f7a6675fc9e906668469
Dependencies: Stopgaps:

Status badges


A bit of background to this fix: Python 3.4 introduced a new API to the multiprocessing module that uses application-specific contexts for all state related to multiprocessing, rather than the old way of relying entirely on module-global state (though there is a concept of a default context). This also enables it to offer different strategies for process spawning.

Here we just keep the existing functionality as-is, but slightly update how the multiprocessing module is used in this module to use a context for it instead, while still keeping backwards compatibility on Python 2.

Change History (4)

comment:1 Changed 4 years ago by embray

  • Status changed from new to needs_review

comment:2 Changed 4 years ago by hivert

  • Cc hivert added
  • Reviewers set to Florent Hivert
  • Status changed from needs_review to positive_review

LGTM ! I need to read more about this new python 3 stuff to look if there is room for improvements.

comment:3 Changed 4 years ago by embray

  • Milestone changed from sage-8.2 to sage-8.3

comment:4 Changed 4 years ago by vbraun

  • Branch changed from u/embray/python3/sage-parallel-map_reduce/ctx to 8f3f013e4e3303954750f7a6675fc9e906668469
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.