Opened 4 years ago

Closed 3 years ago

#25244 closed enhancement (fixed)

LatticePoset: Add is_interval_dismantlable

Reported by: jmantysalo Owned by:
Priority: major Milestone: sage-8.3
Component: combinatorics Keywords:
Cc: tscrim, chapoton Merged in:
Authors: Jori Mäntysalo Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: b064055 (Commits, GitHub, GitLab) Commit: b064055d6c8e52f3c02700abf945f1bee668accf
Dependencies: Stopgaps:

Status badges

Description

This patch add a function to check if a lattice is interval dismantlable.

See https://link.springer.com/content/pdf/10.1007%2Fs11083-017-9422-7.pdf or https://math.hawaii.edu/~jb/decomp4.pdf

Change History (14)

comment:1 Changed 4 years ago by jmantysalo

  • Cc tscrim chapoton added

Currently compiling, so not in needs_review yet.

Contains a non-related change to posets.py.

comment:2 Changed 4 years ago by jmantysalo

  • Branch set to u/jmantysalo/interval-dismantlable

comment:3 Changed 4 years ago by git

  • Commit set to 940ee02c62b0dcfea7021e74cb31e0f067089b01

Branch pushed to git repo; I updated commit sha1. New commits:

940ee02Two corrections.

comment:4 Changed 4 years ago by git

  • Commit changed from 940ee02c62b0dcfea7021e74cb31e0f067089b01 to aa0975428355b2baf4322fff9c8329eb7a1bea84

Branch pushed to git repo; I updated commit sha1. New commits:

aa09754Correct doc.

comment:5 Changed 4 years ago by jmantysalo

  • Status changed from new to needs_review

Now it should work.

The algorithm is not the fastest possible, but as usual, I think it's easier to make better when we have at least a point to compare with.

comment:6 follow-up: Changed 3 years ago by chapoton

one failing doctest, see patchbot report

comment:7 Changed 3 years ago by git

  • Commit changed from aa0975428355b2baf4322fff9c8329eb7a1bea84 to b064055d6c8e52f3c02700abf945f1bee668accf

Branch pushed to git repo; I updated commit sha1. New commits:

b064055Raise (again) limit for gen_rest_table_index.

comment:8 in reply to: ↑ 6 Changed 3 years ago by jmantysalo

Replying to chapoton:

one failing doctest, see patchbot report

Will work for now for nine more functions. I don't like this test.

comment:9 Changed 3 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok

comment:10 follow-up: Changed 3 years ago by chapoton

By the way, I would be interested in having a reasonable "is_congruence_uniform" method.

And if you have some time, would you please try #24994 ?

comment:11 in reply to: ↑ 10 ; follow-up: Changed 3 years ago by jmantysalo

Replying to chapoton:

By the way, I would be interested in having a reasonable "is_congruence_uniform" method.

Do you mean is_uniform or is_constuctible_by_doublings?

And if you have some time, would you please try #24994 ?

I can try, but never before looked at IPython code.

comment:12 in reply to: ↑ 11 ; follow-up: Changed 3 years ago by chapoton

Replying to jmantysalo:

Replying to chapoton:

By the way, I would be interested in having a reasonable "is_congruence_uniform" method.

Do you mean is_uniform or is_constructible_by_doublings?

is_constructible_by_doublings, also called bounded in some references

And if you have some time, would you please try #24994 ?

I can try, but never before looked at IPython code.

Please just simply try the ticket and report if it works.. I suspect that the ipython widgets are broken right now.

comment:13 in reply to: ↑ 12 Changed 3 years ago by jmantysalo

Replying to chapoton:

Replying to jmantysalo:

Replying to chapoton:

By the way, I would be interested in having a reasonable "is_congruence_uniform" method.

Do you mean is_uniform or is_constructible_by_doublings?

is_constructible_by_doublings, also called bounded in some references

What's wrong with our current is_constructible_by_doublings('interval')?

comment:14 Changed 3 years ago by vbraun

  • Branch changed from u/jmantysalo/interval-dismantlable to b064055d6c8e52f3c02700abf945f1bee668accf
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.