#25231 closed defect (fixed)
py3: miscellaneous minor fixes to sage.crypto
Reported by:  embray  Owned by:  

Priority:  minor  Milestone:  sage8.3 
Component:  python3  Keywords:  
Cc:  Merged in:  
Authors:  Erik Bray  Reviewers:  Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  aae8c92 (Commits)  Commit:  
Dependencies:  Stopgaps: 
Description
Change History (12)
comment:1 Changed 2 years ago by
 Commit set to 15b7144f82c73692fe8ae391a08201c293e84bc4
comment:2 Changed 2 years ago by
Oops, totally mixed this up with another branch somehow.
comment:3 Changed 2 years ago by
 Commit changed from 15b7144f82c73692fe8ae391a08201c293e84bc4 to ed88620cc2f598e6df05adbd75838df1b73ac02d
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
c284d77  py3: fix some map() calls that don't work (refs #16073)

4de2b4d  py3: use sage_getargspec instead of plain inspect.getargspec

ed88620  py3: minor test fix to account for tiny difference in exception message formatting

comment:4 Changed 2 years ago by
 Status changed from new to needs_review
comment:5 Changed 2 years ago by
The change to src/sage/rings/polynomial/pbori.pyx
seems not necessary. Cython knows about that, I have been told. But maybe I am wrong.
Otherwise, looks good to me
comment:6 Changed 2 years ago by
Oh, the problem there is that it only works in Cython if the underlying object is actually a dict
. It doesn't work, annoyingly, if it's not exactly a dict
. That said, I had intended to undo that changethe object in question here was a KeyConvertingDict
. But the better approach I found for this is to just add iterkeys/itervalues/iteritems
methods on KeyConvertingDict
for backwards compatibility.
comment:7 Changed 2 years ago by
That change wasn't even supposed to be in this ticket. I'm not sure how it's still there.
comment:8 Changed 2 years ago by
 Commit changed from ed88620cc2f598e6df05adbd75838df1b73ac02d to aae8c920192bc18c845edbd02fec770132cc97c0
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
d52895c  py3: fix some map() calls that don't work (refs #16073)

b74a4d0  py3: use sage_getargspec instead of plain inspect.getargspec

aae8c92  py3: minor test fix to account for tiny difference in exception message formatting

comment:9 Changed 2 years ago by
 Reviewers set to Frédéric Chapoton
 Status changed from needs_review to positive_review
ok
comment:10 Changed 2 years ago by
 Branch changed from u/embray/python3/sagecrypto/misc to aae8c920192bc18c845edbd02fec770132cc97c0
 Resolution set to fixed
 Status changed from positive_review to closed
comment:11 Changed 2 years ago by
 Branch changed from aae8c920192bc18c845edbd02fec770132cc97c0 to u/jhpalmieri/aae8c920192bc18c845edbd02fec770132cc97c0
comment:12 Changed 2 years ago by
 Branch changed from u/jhpalmieri/aae8c920192bc18c845edbd02fec770132cc97c0 to aae8c920192bc18c845edbd02fec770132cc97c0
 Commit aae8c920192bc18c845edbd02fec770132cc97c0 deleted
Sorry, wrong ticket.
Branch pushed to git repo; I updated commit sha1. New commits:
py3: more bytes>str fixes in sage.rings.polynomial.pbori
py3: minor test fixes in sage.rings.polynomial.pbori
whitespace fix