Opened 5 years ago
Last modified 4 weeks ago
#25227 needs_work enhancement
More polynomials should know that they are irreducible
Reported by: | Julian Rüth | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | commutative algebra | Keywords: | padicIMA |
Cc: | Merged in: | ||
Authors: | Julian Rüth | Reviewers: | |
Report Upstream: | N/A | Work issues: | is the patchbot happy? |
Branch: | u/soehms/25227 (Commits, GitHub, GitLab) | Commit: | 8977f19efa7854070d041bb6f3f40fbe063a2a02 |
Dependencies: | #29266 | Stopgaps: |
Description
Change History (17)
comment:1 Changed 5 years ago by
Branch: | → u/saraedum/irreducible |
---|
comment:2 Changed 5 years ago by
Branch: | u/saraedum/irreducible |
---|
comment:3 Changed 5 years ago by
Branch: | → u/saraedum/25227 |
---|
comment:4 Changed 5 years ago by
Commit: | → 847a4e79e3a784a0fb537b411085ae267ad768f2 |
---|
comment:5 Changed 5 years ago by
Work issues: | → docstrings |
---|
comment:6 Changed 5 years ago by
Commit: | 847a4e79e3a784a0fb537b411085ae267ad768f2 → 93e8d519f52958debf1e115469c8f05d0c59cf7e |
---|
comment:7 Changed 5 years ago by
Commit: | 93e8d519f52958debf1e115469c8f05d0c59cf7e → d2bc6fe08c0bee21269c3bb5cbcf1b0224d4f5f4 |
---|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
d2bc6fe | Add docstrings for _is_irreducible_univariate_polynomial()
|
comment:8 Changed 5 years ago by
Status: | new → needs_review |
---|---|
Work issues: | docstrings → is the patchbot happy? |
comment:10 Changed 5 years ago by
Milestone: | sage-8.2 → sage-8.4 |
---|---|
Status: | needs_review → needs_work |
comment:11 Changed 5 years ago by
Commit: | d2bc6fe08c0bee21269c3bb5cbcf1b0224d4f5f4 → 2d43fe7aba045118216109658eb40dbb3fbaaba6 |
---|
comment:12 Changed 5 years ago by
Status: | needs_work → needs_review |
---|
comment:13 Changed 5 years ago by
Keywords: | padicIMA added |
---|
comment:15 Changed 3 years ago by
Branch: | u/saraedum/25227 → u/soehms/25227 |
---|
comment:16 Changed 3 years ago by
Commit: | 2d43fe7aba045118216109658eb40dbb3fbaaba6 → 8977f19efa7854070d041bb6f3f40fbe063a2a02 |
---|---|
Dependencies: | → #29266 |
I rebase the implementation to 9.1.beta5 and insert a dependency to ticket #29266 which fixes a bug of #26421, since the latter one cause one of the doctest to fail.
Note, that the following doctests of the present ticket already worked under the previous stable release 8.1:
┌────────────────────────────────────────────────────────────────────┐ │ SageMath version 8.1, Release Date: 2017-12-07 │ │ Type "notebook()" for the browser-based notebook interface. │ │ Type "help()" for help. │ └────────────────────────────────────────────────────────────────────┘ sage: S.<t> = QQ[] sage: R.<x> = S[] sage: f = t*x sage: f.is_irreducible() False sage: f = t*x + (t+1) sage: f.is_irreducible() True sage: R.<x> = ZZ[] sage: f = 2*x sage: f.is_irreducible() False sage: f = 2*x + 3 sage: f.is_irreducible() True sage:
Therefore, they don't make clear what is improved by the corresponding implementation. I would replace these doctests by examples which don't work without the implementation of the ticket.
New commits:
ffa9302 | Merge branch 'u/saraedum/25227' of git://trac.sagemath.org/sage into more_polynomials_irreducible_25227
|
004c1c4 | 29266 initial version
|
8977f19 | Merge branch 'factorization_integral_domain_29266' into more_polynomials_irreducible_25227
|
comment:17 Changed 4 weeks ago by
Milestone: | sage-8.4 |
---|
Note: See
TracTickets for help on using
tickets.
Branch pushed to git repo; I updated commit sha1. New commits:
Merge develop and 25227