Opened 5 years ago

Last modified 4 weeks ago

#25227 needs_work enhancement

More polynomials should know that they are irreducible

Reported by: Julian Rüth Owned by:
Priority: minor Milestone:
Component: commutative algebra Keywords: padicIMA
Cc: Merged in:
Authors: Julian Rüth Reviewers:
Report Upstream: N/A Work issues: is the patchbot happy?
Branch: u/soehms/25227 (Commits, GitHub, GitLab) Commit: 8977f19efa7854070d041bb6f3f40fbe063a2a02
Dependencies: #29266 Stopgaps:

Status badges

Description


Change History (17)

comment:1 Changed 5 years ago by Julian Rüth

Branch: u/saraedum/irreducible

comment:2 Changed 5 years ago by Julian Rüth

Branch: u/saraedum/irreducible

comment:3 Changed 5 years ago by Julian Rüth

Branch: u/saraedum/25227

comment:4 Changed 5 years ago by git

Commit: 847a4e79e3a784a0fb537b411085ae267ad768f2

Branch pushed to git repo; I updated commit sha1. New commits:

847a4e7Merge develop and 25227

comment:5 Changed 5 years ago by Julian Rüth

Work issues: docstrings

New commits:

57e6d44Teach more rings about irreducible polynomials
cf4bebfMerge remote-tracking branch 'trac/u/saraedum/irreducible' into HEAD
847a4e7Merge develop and 25227

comment:6 Changed 5 years ago by git

Commit: 847a4e79e3a784a0fb537b411085ae267ad768f293e8d519f52958debf1e115469c8f05d0c59cf7e

Branch pushed to git repo; I updated commit sha1. New commits:

3cf6c75Merge develop and 25227
93e8d51Add docstrings for _is_irreducible_univariate_polynomial()

comment:7 Changed 5 years ago by git

Commit: 93e8d519f52958debf1e115469c8f05d0c59cf7ed2bc6fe08c0bee21269c3bb5cbcf1b0224d4f5f4

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d2bc6feAdd docstrings for _is_irreducible_univariate_polynomial()

comment:8 Changed 5 years ago by Julian Rüth

Status: newneeds_review
Work issues: docstringsis the patchbot happy?

comment:9 Changed 5 years ago by Frédéric Chapoton

one doctest failing (typo)

and pyflakes plugin is not happy

comment:10 Changed 5 years ago by Frédéric Chapoton

Milestone: sage-8.2sage-8.4
Status: needs_reviewneeds_work

comment:11 Changed 5 years ago by git

Commit: d2bc6fe08c0bee21269c3bb5cbcf1b0224d4f5f42d43fe7aba045118216109658eb40dbb3fbaaba6

Branch pushed to git repo; I updated commit sha1. New commits:

cacb467silence pyflakes
2d43fe7fix typo

comment:12 Changed 5 years ago by Julian Rüth

Status: needs_workneeds_review

New commits:

cacb467silence pyflakes
2d43fe7fix typo

New commits:

cacb467silence pyflakes
2d43fe7fix typo

comment:13 Changed 5 years ago by David Roe

Keywords: padicIMA added

comment:14 Changed 4 years ago by Frédéric Chapoton

Status: needs_reviewneeds_work

red branch => needs work

comment:15 Changed 3 years ago by Sebastian Oehms

Branch: u/saraedum/25227u/soehms/25227

comment:16 Changed 3 years ago by Sebastian Oehms

Commit: 2d43fe7aba045118216109658eb40dbb3fbaaba68977f19efa7854070d041bb6f3f40fbe063a2a02
Dependencies: #29266

I rebase the implementation to 9.1.beta5 and insert a dependency to ticket #29266 which fixes a bug of #26421, since the latter one cause one of the doctest to fail.

Note, that the following doctests of the present ticket already worked under the previous stable release 8.1:

┌────────────────────────────────────────────────────────────────────┐
│ SageMath version 8.1, Release Date: 2017-12-07                     │
│ Type "notebook()" for the browser-based notebook interface.        │
│ Type "help()" for help.                                            │
└────────────────────────────────────────────────────────────────────┘
sage: S.<t> = QQ[]
sage: R.<x> = S[]
sage: f = t*x
sage: f.is_irreducible()
False
sage: f = t*x + (t+1)
sage: f.is_irreducible()
True
sage: R.<x> = ZZ[]
sage: f = 2*x
sage: f.is_irreducible()
False
sage: f = 2*x + 3
sage: f.is_irreducible()
True
sage:

Therefore, they don't make clear what is improved by the corresponding implementation. I would replace these doctests by examples which don't work without the implementation of the ticket.


New commits:

ffa9302Merge branch 'u/saraedum/25227' of git://trac.sagemath.org/sage into more_polynomials_irreducible_25227
004c1c429266 initial version
8977f19Merge branch 'factorization_integral_domain_29266' into more_polynomials_irreducible_25227

comment:17 Changed 4 weeks ago by Matthias Köppe

Milestone: sage-8.4
Note: See TracTickets for help on using tickets.