Opened 4 years ago

Closed 3 years ago

#25208 closed task (fixed)

Move configure-time checks for OSX/XCode compatibility to a separate macro

Reported by: embray Owned by:
Priority: major Milestone: sage-8.4
Component: build: configure Keywords:
Cc: dimpase Merged in:
Authors: Erik Bray Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 13619ff (Commits, GitHub, GitLab) Commit: 13619ffd7ccc06ca98ef8905f49ca0d3f9bef734
Dependencies: #25118 Stopgaps:

Status badges


Just a little further cleanup. This is a big chunk of code that deserves to be centralized in one place if/when further updates to it are needed.

Change History (9)

comment:1 Changed 4 years ago by embray

  • Dependencies set to #25118

comment:2 Changed 3 years ago by embray

  • Status changed from new to needs_review

Forgot about this one.

comment:3 Changed 3 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

looks innocent enough..

comment:4 Changed 3 years ago by embray

Yes, it's just a verbatim code move--no changes otherwise. I'm trying to make the shorter and easier to read.

comment:5 Changed 3 years ago by dimpase

let me test this on OSX...

comment:6 follow-up: Changed 3 years ago by dimpase

OK, it's fine.

comment:7 in reply to: ↑ 6 Changed 3 years ago by embray

Replying to dimpase:

OK, it's fine.


comment:8 Changed 3 years ago by embray

  • Milestone changed from sage-8.3 to sage-8.4

I believe this issue can reasonably be addressed for Sage 8.4.

comment:9 Changed 3 years ago by vbraun

  • Branch changed from u/embray/build-configure/darwin-macro to 13619ffd7ccc06ca98ef8905f49ca0d3f9bef734
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.