Opened 4 years ago

Closed 4 years ago

#25189 closed defect (fixed)

Upgrade cysignals to version 1.7.1

Reported by: jdemeyer Owned by:
Priority: blocker Milestone: sage-8.3
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Vincent Klein
Report Upstream: N/A Work issues:
Branch: 4ed886b (Commits, GitHub, GitLab) Commit: 4ed886b8dab273279e49e6ca818c96df8f4fc8c8
Dependencies: Stopgaps:

Status badges

Change History (14)

comment:1 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:3 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/upgrade_cysignals_to_version_1_7_1

comment:4 Changed 4 years ago by jdemeyer

  • Commit set to 4ed886b8dab273279e49e6ca818c96df8f4fc8c8
  • Status changed from new to needs_review

New commits:

4ed886bUpgrade cysignals to version 1.7.1

comment:5 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:6 follow-up: Changed 4 years ago by vbraun

  • Priority changed from blocker to major

Thats not a supported platform -> next beta cycle

comment:7 in reply to: ↑ 6 Changed 4 years ago by jdemeyer

  • Priority changed from major to blocker

Replying to vbraun:

Thats not a supported platform

What's your definition of "supported platform" and why does this system not satisfy?

Previous versions of Sage worked perfectly with 100% doctests passing and I actually use this machine for serious stuff (i.e. it's not a museum machine that I only use to annoy release managers with bug reports).

PS: I know that I've been messing up with cysignals breakage in this release cycle, but there is always some strange OS quirk that comes up.

comment:8 follow-up: Changed 4 years ago by vbraun

Imho supported platform requires having a buildbot

The 2 users of Sage on that arch can just follow the develop branch.

We've seen how easy it is to break something by mucking with signal handlers in this release cycle, so I'm against last minute changes if they can be avoided

comment:9 in reply to: ↑ 8 Changed 4 years ago by jdemeyer

Replying to vbraun:

Imho supported platform requires having a buildbot

That just means that we should put a buildbot on that machine. For a while now, I have a patchbot running there.

The 2 users of Sage on that arch can just follow the develop branch.

Can't argue with that I guess.

We've seen how easy it is to break something by mucking with signal handlers in this release cycle, so I'm against last minute changes if they can be avoided

If it helps, there are no actual changes to signal handling, only to threading :-)

comment:10 Changed 4 years ago by vbraun

  • Priority changed from blocker to major

comment:11 Changed 4 years ago by vklein

  • Reviewers set to Vincent Klein

All tests run for me. Let me know if you see more specific test to do.

comment:12 Changed 4 years ago by vklein

  • Status changed from needs_review to positive_review

comment:13 Changed 4 years ago by jdemeyer

  • Milestone changed from sage-8.2 to sage-8.3
  • Priority changed from major to blocker

@vbraun: can we at least make this a 8.3 blocker then, in the sense that it should be merged with priority in the 8.3 branch?

comment:14 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/upgrade_cysignals_to_version_1_7_1 to 4ed886b8dab273279e49e6ca818c96df8f4fc8c8
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.