Opened 3 years ago

Closed 3 years ago

#25169 closed enhancement (fixed)

py3: fixing print in sage-starts script

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.2
Component: python3 Keywords:
Cc: jdemeyer, embray, fbissey Merged in:
Authors: Frédéric Chapoton Reviewers: Samuel Lelièvre
Report Upstream: N/A Work issues:
Branch: a214267 (Commits, GitHub, GitLab) Commit: a214267c315a9406bde1e7224682e1da5272fbeb
Dependencies: Stopgaps:

Status badges

Description (last modified by slelievre)

In a python3-sage run of the patchbot: 

Testing that Sage starts...
[2018-04-14 19:22:09] SageMath version 8.2.rc2, Release Date: 2018-04-10
This looks like the first time you are running Sage.
Cleaning up, do not interrupt this.
Done cleaning.
Traceback (most recent call last):
  File "/home/chapoton/sage3/src/bin/sage-eval", line 10, in <module>
    eval(compile(s,'<cmdline>','exec'))
  File "<cmdline>", line 1
    sage.all._write_started_file(); print "Yes, Sage starts."
                                                            ^
SyntaxError: invalid syntax
Sage failed to start up.
Please email sage-devel (http://groups.google.com/group/sage-devel)

The solution is to make this print (originally a Python2 print statement) compatible with the Python3 print function.

Change History (3)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/25169
  • Commit set to a214267c315a9406bde1e7224682e1da5272fbeb
  • Status changed from new to needs_review

New commits:

​a214267fixing a bad print

comment:2 Changed 3 years ago by slelievre

  • Description modified (diff)
  • Reviewers set to Samuel Lelièvre
  • Status changed from needs_review to positive_review

comment:3 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/25169 to a214267c315a9406bde1e7224682e1da5272fbeb
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.