Opened 5 years ago

Closed 5 years ago

#25129 closed defect (fixed)

Fix "offline" viewing of threejs plots on Cygwin

Reported by: Erik Bray Owned by:
Priority: critical Milestone: sage-8.3
Component: porting: Cygwin Keywords:
Cc: Merged in:
Authors: Erik Bray Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: b373347 (Commits, GitHub, GitLab) Commit: b373347fc2cdbc6b2407f3e7599ac0bd1e1d20b1
Dependencies: #25016 Stopgaps:

Status badges

Description

As raised here and I believe elsewhere as well, viewing threejs plots does not work on Windows if "offline" scripts are used (i.e. the scripts included in Sage) since the correct Windows-style paths are not output to the HTML template.

It would be nice to get this fixed ASAP, but it should have a workaround in the form of using the "online" scripts, in which case the scripts are downloaded over the internet.

Change History (4)

comment:1 Changed 5 years ago by Erik Bray

Dependencies: #25016
Status: newneeds_review

comment:2 Changed 5 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

LGTM.

comment:3 Changed 5 years ago by Erik Bray

Milestone: sage-8.2sage-8.3

comment:4 Changed 5 years ago by Volker Braun

Branch: u/embray/pkgs/cygwin/threejs-offlineb373347fc2cdbc6b2407f3e7599ac0bd1e1d20b1
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.