#25129 closed defect (fixed)

Fix "offline" viewing of threejs plots on Cygwin

Reported by: embray Owned by:
Priority: critical Milestone: sage-8.3
Component: porting: Cygwin Keywords:
Cc: Merged in:
Authors: Erik Bray Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: b373347 (Commits) Commit: b373347fc2cdbc6b2407f3e7599ac0bd1e1d20b1
Dependencies: #25016 Stopgaps:

Description

As raised here and I believe elsewhere as well, viewing threejs plots does not work on Windows if "offline" scripts are used (i.e. the scripts included in Sage) since the correct Windows-style paths are not output to the HTML template.

It would be nice to get this fixed ASAP, but it should have a workaround in the form of using the "online" scripts, in which case the scripts are downloaded over the internet.

Change History (4)

comment:1 Changed 11 months ago by embray

  • Dependencies set to #25016
  • Status changed from new to needs_review

comment:2 Changed 10 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:3 Changed 10 months ago by embray

  • Milestone changed from sage-8.2 to sage-8.3

comment:4 Changed 10 months ago by vbraun

  • Branch changed from u/embray/pkgs/cygwin/threejs-offline to b373347fc2cdbc6b2407f3e7599ac0bd1e1d20b1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.