Opened 6 months ago
Closed 5 months ago
#25126 closed defect (fixed)
Factoring disconnected graph
Reported by:  jmantysalo  Owned by:  

Priority:  minor  Milestone:  sage8.3 
Component:  graph theory  Keywords:  
Cc:  chapoton  Merged in:  
Authors:  Jori Mäntysalo  Reviewers:  David Coudert 
Report Upstream:  N/A  Work issues:  
Branch:  1efb9ba (Commits)  Commit:  1efb9ba183079fd7e0706218e81d21f2fbe38f30 
Dependencies:  Stopgaps: 
Description
Currently Graph(4).is_cartesian_product()
raises ValueError
and Graph(5).is_cartesian_product()
returns False
. This patch makes both to raise NotImplementedError
.
Change History (9)
comment:1 Changed 6 months ago by
 Branch set to u/jmantysalo/factorunconnected
comment:2 Changed 6 months ago by
 Cc chapoton added
 Commit set to 6e068fc1ff56a7f010d4a0c2ad6741e10d1015b8
 Status changed from new to needs_review
comment:3 followup: ↓ 5 Changed 6 months ago by
Please use either "disconnected" or "non connected", but not "unconnected" that I have never seen in any graph theory paper.
comment:4 Changed 6 months ago by
 Commit changed from 6e068fc1ff56a7f010d4a0c2ad6741e10d1015b8 to 1efb9ba183079fd7e0706218e81d21f2fbe38f30
Branch pushed to git repo; I updated commit sha1. New commits:
1efb9ba  'unconnected' > 'disconnected'.

comment:5 in reply to: ↑ 3 Changed 6 months ago by
Replying to dcoudert:
Please use either "disconnected" or "non connected", but not "unconnected" that I have never seen in any graph theory paper.
Good point, corrected.
comment:6 followup: ↓ 7 Changed 6 months ago by
 Reviewers set to David Coudert
 Status changed from needs_review to positive_review
 Summary changed from Factoring unconnected graph to Factoring disconnected graph
Thanks.
I changed the title of the ticket.
comment:7 in reply to: ↑ 6 Changed 6 months ago by
comment:8 Changed 6 months ago by
 Milestone changed from sage8.2 to sage8.3
comment:9 Changed 5 months ago by
 Branch changed from u/jmantysalo/factorunconnected to 1efb9ba183079fd7e0706218e81d21f2fbe38f30
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Change error type.