Opened 5 years ago

Closed 5 years ago

#25088 closed defect (fixed)

Fix miscellaneous issues with Jmol, particularly on newer Java versions

Reported by: embray Owned by:
Priority: blocker Milestone: sage-8.2
Component: graphics Keywords: jmol
Cc: Merged in:
Authors: Erik Bray Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: db5ab23 (Commits, GitHub, GitLab) Commit: db5ab23d045b879bcc47084b92414de81e98169c
Dependencies: Stopgaps:

GitHub link to the corresponding issue

Description

This fixes a couple minor issues that were discussed in #25026, but are largely independent of the Jmol version itself.

Change History (4)

comment:1 Changed 5 years ago by embray

Status: newneeds_review

comment:2 Changed 5 years ago by git

Commit: 67b7c3e965fe95742334cc2915091aa54b0fb3e0db5ab23d045b879bcc47084b92414de81e98169c

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

db5ab23In the Jmol interface, support image outputs that contain spaces in their paths

comment:3 Changed 5 years ago by vbraun

Reviewers: Volker Braun
Status: needs_reviewpositive_review

comment:4 Changed 5 years ago by vbraun

Branch: u/embray/misc/jmol/misc-issuesdb5ab23d045b879bcc47084b92414de81e98169c
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.