Opened 4 years ago

Closed 4 years ago

#25088 closed defect (fixed)

Fix miscellaneous issues with Jmol, particularly on newer Java versions

Reported by: embray Owned by:
Priority: blocker Milestone: sage-8.2
Component: graphics Keywords: jmol
Cc: Merged in:
Authors: Erik Bray Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: db5ab23 (Commits, GitHub, GitLab) Commit: db5ab23d045b879bcc47084b92414de81e98169c
Dependencies: Stopgaps:

Status badges

Description

This fixes a couple minor issues that were discussed in #25026, but are largely independent of the Jmol version itself.

Change History (4)

comment:1 Changed 4 years ago by embray

  • Status changed from new to needs_review

comment:2 Changed 4 years ago by git

  • Commit changed from 67b7c3e965fe95742334cc2915091aa54b0fb3e0 to db5ab23d045b879bcc47084b92414de81e98169c

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​db5ab23In the Jmol interface, support image outputs that contain spaces in their paths

comment:3 Changed 4 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:4 Changed 4 years ago by vbraun

  • Branch changed from u/embray/misc/jmol/misc-issues to db5ab23d045b879bcc47084b92414de81e98169c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.