Opened 2 years ago

Closed 23 months ago

#25081 closed defect (fixed)

The polar of a polyhedron should carry the backend used.

Reported by: jipilab Owned by:
Priority: major Milestone: sage-8.2
Component: geometry Keywords: polytope, polar, IMA-PolyGeom
Cc: vdelecroix, moritz, mkoeppe, gh-sebasguts Merged in:
Authors: Jean-Philippe Labbé Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: 25561e7 (Commits) Commit: 25561e71bec326d197836caa43440d9d7d3d44a8
Dependencies: Stopgaps:

Description (last modified by jipilab)

Currently, sage does not carry the backend used when creating the polar polyhedron object:

sage: C = polytopes.hypercube(4,backend='cdd')
sage: C.polar().backend()

For consistency, it would make sense that sage tries to keep the backend used by self.

Change History (6)

comment:1 Changed 2 years ago by jipilab

  • Authors set to Jean-Philippe Labbé
  • Description modified (diff)

comment:2 follow-up: Changed 2 years ago by moritz

sounds reasonable; do all backends that can handle ZZ, also can handle QQ?

comment:3 in reply to: ↑ 2 Changed 2 years ago by jipilab

Replying to moritz:

sounds reasonable; do all backends that can handle ZZ, also can handle QQ?

Yes; there is no real difference between ZZ and QQ at the backend level. The difference between a ZZ polyhedron and QQ polyhedron inside sage is somewhat artificial.

comment:4 Changed 2 years ago by jipilab

  • Branch set to u/jipilab/25081
  • Commit set to 25561e71bec326d197836caa43440d9d7d3d44a8
  • Status changed from new to needs_review

Have a nice trip Moritz!

New commits:

25561e7Fixed the backend in polar

comment:5 Changed 2 years ago by mkoeppe

  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review

comment:6 Changed 23 months ago by vbraun

  • Branch changed from u/jipilab/25081 to 25561e71bec326d197836caa43440d9d7d3d44a8
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.