Opened 4 years ago

Closed 4 years ago

#25077 closed defect (fixed)

Broken doctest involving TotallyOrderedFiniteSet

Reported by: jdemeyer Owned by:
Priority: blocker Milestone: sage-8.2
Component: doctest coverage Keywords:
Cc: vdelecroix, embray Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: e9b79ca (Commits, GitHub, GitLab) Commit: e9b79cac36fe29533763973fcb5659e4ccf4a3eb
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

This is most likely caused by #24968:

sage -t src/sage/sets/totally_ordered_finite_set.py
**********************************************************************
File "src/sage/sets/totally_ordered_finite_set.py", line 218, in sage.sets.totally_ordered_finite_set.TotallyOrderedFiniteSet
Failed example:
    for e in [1,'a',(0, 0)]:
        f = A(e)
        l = (e == f,
             cmp(e,f) == cmp(type(e),type(f)),
             cmp(f,e) == cmp(type(f),type(e)))
        print(l)
Expected:
    (False, True, True)
    (False, True, True)
    (False, True, True)
Got:
    (False, False, False)
    (False, True, True)
    (False, False, False)
**********************************************************************

Change History (5)

comment:1 Changed 4 years ago by jdemeyer

  • Cc embray added
  • Description modified (diff)

comment:2 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/broken_doctest_involving_totallyorderedfiniteset

comment:3 Changed 4 years ago by jdemeyer

  • Cc vdelecroix added
  • Commit set to e9b79cac36fe29533763973fcb5659e4ccf4a3eb
  • Status changed from new to needs_review

New commits:

e9b79caRemove broken test involving cmp()

comment:4 Changed 4 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok

comment:5 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/broken_doctest_involving_totallyorderedfiniteset to e9b79cac36fe29533763973fcb5659e4ccf4a3eb
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.