Opened 4 years ago

Closed 4 years ago

#25060 closed enhancement (fixed)

py3: more rich comparison for multivariate polynomials

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.2
Component: python3 Keywords: python3, richcmp
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: b656bfc (Commits, GitHub, GitLab) Commit: b656bfccaf61c012e4a27a3a70ad1a2bd3e9c1fe
Dependencies: Stopgaps:

Status badges

Description

part of #16537

Change History (8)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/25060
  • Commit set to 31c4370adcfe8cdb06e372e1834c1892e7393739
  • Status changed from new to needs_review

New commits:

31c4370more rich comparison in multi-variate polynomials

comment:2 Changed 4 years ago by jdemeyer

Wouldn't it have been sufficient (and much simpler) to replace __cmp__ by _cmp_?

comment:3 Changed 4 years ago by jdemeyer

  • Status changed from needs_review to needs_work

Unless I'm missing something, it seems that the key argument is required, so the except AttributeError branch should be removed.

And given that key is required, replace key=None by key in the method signature.

comment:4 Changed 4 years ago by git

  • Commit changed from 31c4370adcfe8cdb06e372e1834c1892e7393739 to b656bfccaf61c012e4a27a3a70ad1a2bd3e9c1fe

Branch pushed to git repo; I updated commit sha1. New commits:

b656bfcsome details

comment:5 Changed 4 years ago by chapoton

  • Status changed from needs_work to needs_review

done, thanks

comment:6 Changed 4 years ago by chapoton

and bot is green

comment:7 Changed 4 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:8 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/25060 to b656bfccaf61c012e4a27a3a70ad1a2bd3e9c1fe
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.