Opened 5 years ago

Closed 5 years ago

#25025 closed defect (fixed)

Fix jmol package in Cygwin

Reported by: embray Owned by:
Priority: blocker Milestone: sage-8.2
Component: porting: Cygwin Keywords:
Cc: Merged in:
Authors: Erik Bray Reviewers: Julian Rüth
Report Upstream: N/A Work issues:
Branch: 880330f (Commits, GitHub, GitLab) Commit: 880330fc5f4c80782e25e23a53eebc4826728758
Dependencies: #25021 Stopgaps:

GitHub link to the corresponding issue

Description

This does two things: 1) Original motivation is to ensure a Windows native path is used when passing the path to Jmol.jar to the java interpreter.

2) Cleans things up a bit by providing our own, slightly simpler jmol script as opposed to the script that comes with the jmol binary package, rather than patching that script.

Change History (5)

comment:1 Changed 5 years ago by embray

Priority: majorcritical
Status: newneeds_review

I feel this is fairly critical actually--although in most cases threejs should probably be preferred at this point over jmol, I still get lots of users on ask.sagemath.org having problems with this.

comment:2 Changed 5 years ago by embray

Dependencies: #25021

comment:3 Changed 5 years ago by saraedum

Reviewers: Julian Rüth
Status: needs_reviewpositive_review

comment:4 Changed 5 years ago by embray

Priority: criticalblocker

comment:5 Changed 5 years ago by vbraun

Branch: u/embray/cygwin/jmol-paths880330fc5f4c80782e25e23a53eebc4826728758
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.