Opened 5 years ago

Closed 5 years ago

#25021 closed enhancement (fixed)

Update the jmol SPKG with DESTDIR support

Reported by: Erik Bray Owned by:
Priority: major Milestone: sage-8.2
Component: build Keywords:
Cc: Merged in:
Authors: Erik Bray Reviewers: Julian Rüth
Report Upstream: N/A Work issues:
Branch: d525312 (Commits, GitHub, GitLab) Commit: d525312341f22a0f424a2101f18f375d1922469d
Dependencies: #25001 Stopgaps:

Status badges


Part of #24024 / #22509.

Change History (7)

comment:1 Changed 5 years ago by Erik Bray

I don't think this should necessitate a version bump since it doesn't change anything about the end result--if someone wants a record of the files installed by this package they can still manually reinstall it with ./sage -f.

In any case I will have a follow-up ticket soon that will necessitate a version bump to this package.

comment:2 Changed 5 years ago by Erik Bray

Dependencies: #25001

comment:3 Changed 5 years ago by git

Commit: ce235572fe023eb1789602ffeee6fde9002d5dded525312341f22a0f424a2101f18f375d1922469d

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

330e618Introduce SAGE_DESTDIR_LOCAL variable
9d14972Don't install gcc as part of gfortran
d525312Slight reworking of spkg-install for jmol to support DESTDIR installs and to use sage-dist-helpers where appropriate

comment:4 Changed 5 years ago by Erik Bray

Status: newneeds_review

comment:5 Changed 5 years ago by Julian Rüth

Reviewers: Julian Rüth

Looks good to me. If you have tried this out on the relevant platforms, feel free to set it to positive review.

comment:6 Changed 5 years ago by Erik Bray

Status: needs_reviewpositive_review

comment:7 Changed 5 years ago by Volker Braun

Branch: u/embray/build/destdir-jmold525312341f22a0f424a2101f18f375d1922469d
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.