Opened 5 years ago
Closed 5 years ago
#25020 closed enhancement (fixed)
Some updates to use pycygwin
Reported by: | Erik Bray | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-8.3 |
Component: | porting: Cygwin | Keywords: | |
Cc: | Merged in: | ||
Authors: | Erik Bray | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 692ad4a (Commits, GitHub, GitLab) | Commit: | 692ad4ab8fa30c8c4bdca337e286a3ed29bd9eed |
Dependencies: | #25016 | Stopgaps: |
Description
Updates a few modules to use the cygwin.cygpath
function instead of running a subprocess to use cygpath
(one of the main reasons for PyCygwin).
Change History (8)
comment:1 Changed 5 years ago by
Status: | new → needs_review |
---|
comment:2 Changed 5 years ago by
Reviewers: | → Travis Scrimshaw |
---|---|
Status: | needs_review → positive_review |
comment:3 Changed 5 years ago by
Milestone: | sage-8.2 → sage-8.3 |
---|
comment:5 Changed 5 years ago by
Commit: | dc60eec8a2c8fe11509b448a74de074f241bd906 → 692ad4ab8fa30c8c4bdca337e286a3ed29bd9eed |
---|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
692ad4a | use the cygwin module for cygpath instead of running a subprocess
|
comment:6 Changed 5 years ago by
Status: | needs_work → needs_review |
---|
comment:7 Changed 5 years ago by
Status: | needs_review → positive_review |
---|
comment:8 Changed 5 years ago by
Branch: | u/embray/cygwin/path-issues → 692ad4ab8fa30c8c4bdca337e286a3ed29bd9eed |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
LGTM.