Opened 5 years ago

Closed 5 years ago

#25016 closed enhancement (fixed)

Add PyCygwin as a standard package

Reported by: embray Owned by:
Priority: major Milestone: sage-8.3
Component: packages: standard Keywords: cygwin pycygwin
Cc: Merged in:
Authors: Erik Bray Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: de493a9 (Commits, GitHub, GitLab) Commit: de493a9a3113fdcc281a17e6ac4ee3c94661f5d9
Dependencies: Stopgaps:

Status badges

Description (last modified by embray)

Adds ​PyCygwin as a standard package, though only actually installed on Cygwin.

This is a little project I've been working on off-and-on to provide Python binding's for Cygwin's C-level API. It's far from complete but I made an initial release since I would like to have even this small amount of functionality for fixing a few Cygwin-related issues in Sage.

Upstream tarball: ​https://pypi.python.org/packages/91/5d/811f0656501bad32456b3c52ffcaddc085084aad6b9f4feb6e1605e3a49a/PyCygwin-0.1.tar.gz

Change History (12)

comment:1 Changed 5 years ago by embray

Description: modified (diff)
Status: new → needs_review

comment:2 Changed 5 years ago by jdemeyer

Looking at your upstream sources, this reminds that we should work with Cython upstream to improve the build/packaging of Cython projects.

comment:3 Changed 5 years ago by jdemeyer

There is some strange indendation in build/make/deps.

comment:4 Changed 5 years ago by jdemeyer

Status: needs_review → needs_work

comment:5 in reply to:  2 Changed 5 years ago by embray

Replying to jdemeyer:

Looking at your upstream sources, this reminds that we should work with Cython upstream to improve the build/packaging of Cython projects.

Indeed, I actually have an open issue for that on Cython (just search "build_cython" in their github) but I haven't pursued it lately.

comment:6 Changed 5 years ago by git

Commit: 5ac3c2d700fb3592b02790f09862a4a628e06b39 → 6f9d21de3c3e41a3368acc2f5bdc0cf3b7de7765

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​6f9d21dadd pycygwin as a standard package (only actually installed on Cygwin though)

comment:7 in reply to:  3 Changed 5 years ago by embray

Status: needs_work → needs_review

Replying to jdemeyer:

There is some strange indendation in build/make/deps.

Indeed, I had spaces when the other lines begin with tabs. Doesn't really matter in that particular case but fixed anyway.

New commits:

​6f9d21dadd pycygwin as a standard package (only actually installed on Cygwin though)

comment:8 Changed 5 years ago by embray

Nope. Still not fixed. Ugh, I hate tabs.

comment:9 Changed 5 years ago by git

Commit: 6f9d21de3c3e41a3368acc2f5bdc0cf3b7de7765 → de493a9a3113fdcc281a17e6ac4ee3c94661f5d9

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​de493a9add pycygwin as a standard package (only actually installed on Cygwin though)

comment:10 Changed 5 years ago by jdemeyer

Reviewers: → Jeroen Demeyer
Status: needs_review → positive_review

This is obviously fine given that it only affects cygwin.

comment:11 Changed 5 years ago by embray

Milestone: sage-8.2 → sage-8.3

comment:12 Changed 5 years ago by vbraun

Branch: u/embray/pkgs/pycygwin → de493a9a3113fdcc281a17e6ac4ee3c94661f5d9
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.