Opened 2 years ago

Closed 2 years ago

#24995 closed defect (fixed)

$(SAGERUNTIME) dependency broken

Reported by: jdemeyer Owned by: embray
Priority: blocker Milestone: sage-8.2
Component: build Keywords:
Cc: embray Merged in:
Authors: Erik Bray Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 4ed2985 (Commits) Commit: 4ed29850d6d475f3d3ec164da54559d7a0db3677
Dependencies: #24996 Stopgaps:

Description (last modified by jdemeyer)

Since 8.2.beta8, the $(SAGERUNTIME) dependency in build/make/Makefile does not work correctly. For example, after installing sagetex (which should install $(SAGERUNTIME)):

[sagetex-3.0] Successfully installed sagetex-3.0
[sagetex-3.0] Deleting temporary build directory
[sagetex-3.0] /home/jdemeyer/sage-test/local/var/tmp/sage/build/sagetex-3.0
[sagetex-3.0] Finished installing sagetex-3.0.spkg
make[1]: Leaving directory '/home/jdemeyer/sage-test/build/make'

real    34m15.561s
user    126m0.208s
sys     11m21.576s
Sage build/upgrade complete!
jdemeyer@sardonis:~/sage-test$ ./sage
************************************************************************
It seems that you are attempting to run Sage from an unpacked source
tarball, but you have not compiled it yet (or maybe the build has not
finished). You should run `make` in the Sage root directory first.
If you did not intend to build Sage from source, you should download
a binary tarball instead. Read README.txt for more information.
************************************************************************

Change History (17)

comment:1 Changed 2 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 2 years ago by embray

  • Owner changed from (none) to embray

I just discovered $(SAGERUNTIME) recently myself, while looking into some other issue. I think it's just defined a little too late in the Makefile now.

comment:3 Changed 2 years ago by embray

Although, that shouldn't matter since it should be expanded recursively. Hmm.

comment:4 Changed 2 years ago by embray

Okay, I see the problem. It's assuming that the only dependencies of some SPKG can be other SPKGs, but not arbitrary files.

comment:5 follow-up: Changed 2 years ago by embray

  • Authors set to Erik Bray
  • Branch set to u/embray/build/ticket-24995
  • Commit set to 849ad286b8d3d7e5ad32de6c330c1fda7916cd4f

I think this should fix it, but I'm still testing.


New commits:

849ad28Allow any SPKG dependency that is not a package name (in which case it is taken verbatime.

comment:6 Changed 2 years ago by embray

Oops, $(value ...) should just be the variable name, not its value of course.

comment:7 Changed 2 years ago by git

  • Commit changed from 849ad286b8d3d7e5ad32de6c330c1fda7916cd4f to 59190b5f68ecd6e806e769ee256d66bb8b387b6c

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

59190b5Allow any SPKG dependency that is not a package name (in which case it is taken verbatime.

comment:8 in reply to: ↑ 5 Changed 2 years ago by jdemeyer

Replying to embray:

I think this should fix it, but I'm still testing.

Don't forget to set this to needs_review when you are done.

comment:9 Changed 2 years ago by embray

Seems to work.

I'm still having some problems when building things in a non-standard order around libpng and m4rie, but I don't think that's related to this.

comment:10 Changed 2 years ago by embray

  • Status changed from new to needs_review

comment:11 follow-up: Changed 2 years ago by git

  • Commit changed from 59190b5f68ecd6e806e769ee256d66bb8b387b6c to 32319581cbecd6cf0103b8089265d30fe9a43817

Branch pushed to git repo; I updated commit sha1. New commits:

3231958Add missing dependency of scandir for pathlib2

comment:12 Changed 2 years ago by jdemeyer

  • Branch changed from u/embray/build/ticket-24995 to u/jdemeyer/build/ticket-24995

comment:13 Changed 2 years ago by jdemeyer

  • Commit changed from 32319581cbecd6cf0103b8089265d30fe9a43817 to 4ed29850d6d475f3d3ec164da54559d7a0db3677
  • Dependencies set to #24996

New commits:

282427cpathlib2 depends on scandir
4ed2985Allow any SPKG dependency that is not a package name (in which case it is taken verbatime.

comment:14 in reply to: ↑ 11 Changed 2 years ago by jdemeyer

Replying to git:

Branch pushed to git repo; I updated commit sha1. New commits:

3231958Add missing dependency of scandir for pathlib2

I already had a ticket for that: #24996

comment:15 Changed 2 years ago by embray

Oops--thanks.

comment:16 Changed 2 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:17 Changed 2 years ago by vbraun

  • Branch changed from u/jdemeyer/build/ticket-24995 to 4ed29850d6d475f3d3ec164da54559d7a0db3677
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.