#24976 closed enhancement (fixed)

add parameter solver to comparability methods

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.3
Component: graph theory Keywords:
Cc: mkoeppe, jmantysalo Merged in:
Authors: David Coudert Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 85823d9 (Commits) Commit: 85823d90ac7c8019fb5753849ab8686b32a397b3
Dependencies: Stopgaps:

Description

Part of #20416.

  • add arguments solver and verbose to methods in src/sage/graphs/comparability.pyx
  • clean some links

Change History (10)

comment:1 Changed 17 months ago by dcoudert

  • Branch set to u/dcoudert/24976_comparability
  • Cc mkoeppe added
  • Commit set to ae9686352d7aa97bb0b478f1066d73548563e662
  • Status changed from new to needs_review

New commits:

ae96863trac #24976: add parameters solver and verbose to methods in comparability

comment:2 Changed 15 months ago by git

  • Commit changed from ae9686352d7aa97bb0b478f1066d73548563e662 to bf81c5afc122edd1448b974d6d7fdada9ee31098

Branch pushed to git repo; I updated commit sha1. New commits:

bf81c5atrac #24976: Merged with 8.3.beta0

comment:3 Changed 15 months ago by dcoudert

  • Milestone changed from sage-8.2 to sage-8.3

comment:4 follow-up: Changed 15 months ago by tscrim

  • Reviewers set to Travis Scrimshaw

Just some PEP8 nitpicks:

def is_comparability(g, algorithm="greedy", certificate=False, check=True,
                     solver=None, verbose=0):
        comparability_test = is_comparability_MILP(g, certificate=certificate,
                                                   solver=solver, verbose=verbose)
        return (is_comparability(g, algorithm=algorithm, solver=solver, verbose=verbose) and
                is_comparability(g.complement(), algorithm=algorithm, solver=solver, verbose=verbose))

(and similar). Once changed (or ignored), you can set a positive review on my behalf.

comment:5 Changed 14 months ago by git

  • Commit changed from bf81c5afc122edd1448b974d6d7fdada9ee31098 to a0b8396bb41813297ab828e6a85a2783b98a399b

Branch pushed to git repo; I updated commit sha1. New commits:

a0b8396trac #24976: PEP8

comment:6 Changed 14 months ago by git

  • Commit changed from a0b8396bb41813297ab828e6a85a2783b98a399b to 85823d90ac7c8019fb5753849ab8686b32a397b3

Branch pushed to git repo; I updated commit sha1. New commits:

85823d9trac #24976: Merged with 8.3.beta5

comment:7 Changed 14 months ago by dcoudert

  • Cc jmantysalo added
  • Summary changed from add parameter solver to method comparability methods to add parameter solver to comparability methods

comment:8 in reply to: ↑ 4 Changed 13 months ago by dcoudert

Once changed (or ignored), you can set a positive review on my behalf.

I have not set this ticket to positive review. Can I ?

comment:9 Changed 13 months ago by tscrim

  • Status changed from needs_review to positive_review

Sorry, because I am not on cc, simple pushes do not send me email updates. Yep, LGTM. Thanks.

comment:10 Changed 13 months ago by vbraun

  • Branch changed from u/dcoudert/24976_comparability to 85823d90ac7c8019fb5753849ab8686b32a397b3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.