Opened 3 years ago
Closed 3 years ago
#24926 closed enhancement (fixed)
add names to some strongly regular graphs
Reported by: | gh-dimpase | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-8.2 |
Component: | graph theory | Keywords: | |
Cc: | Merged in: | ||
Authors: | Dima Pasechnik | Reviewers: | Frédéric Chapoton |
Report Upstream: | N/A | Work issues: | |
Branch: | 2f69054 (Commits, GitHub, GitLab) | Commit: | 2f6905462bb0148ade9bb0b553b3dc0698590dc2 |
Dependencies: | Stopgaps: |
Description
some strongly regular graphs should not have their names empty, e.g. SRG_276_140_58_84 should get Haemers-Tonchev
Change History (10)
comment:1 Changed 3 years ago by
- Priority changed from major to minor
comment:2 Changed 3 years ago by
- Branch set to u/dimpase/graphnames
- Commit set to 80726679cee74eaacaab87b88fcd7897b4fbd551
comment:4 Changed 3 years ago by
it's not done yet, I'll add more... :-) But thanks for looking at it.
comment:5 Changed 3 years ago by
- Commit changed from 80726679cee74eaacaab87b88fcd7897b4fbd551 to dbdbd52a538261377d29cab88f02110a59a3fde0
comment:6 Changed 3 years ago by
it also needs a bit of work on py3 side - I notice that there is no
from __future__ import division
in the file I hack on, and adding it breaks some stuff.
comment:7 Changed 3 years ago by
- Commit changed from dbdbd52a538261377d29cab88f02110a59a3fde0 to 2f6905462bb0148ade9bb0b553b3dc0698590dc2
Branch pushed to git repo; I updated commit sha1. New commits:
2f69054 | import division from __future__ and sanitise / -> //
|
comment:8 Changed 3 years ago by
- Status changed from new to needs_review
OK, done. I wonder how much code in Sage still needs to be dealt in regard of py3 division. We certainly seldom want automatic conversion into floats...
comment:9 Changed 3 years ago by
- Status changed from needs_review to positive_review
ok, thanks.
Concerning division, this file was maybe one of the largest can of issues remaining.
comment:10 Changed 3 years ago by
- Branch changed from u/dimpase/graphnames to 2f6905462bb0148ade9bb0b553b3dc0698590dc2
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
Haemers-Tonchev graph gets a name