Opened 4 years ago

Closed 4 years ago

#24899 closed enhancement (fixed)

py3: using richcmp in p1list.pyx

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.2
Component: python3 Keywords: python3, richcmp
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Julian Rüth
Report Upstream: N/A Work issues:
Branch: 353638b (Commits, GitHub, GitLab) Commit: 353638bc759a87620fd7f801002f14cb3c53c97c
Dependencies: Stopgaps:

Status badges


part of #16537

Change History (6)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/24899
  • Commit set to 353638bc759a87620fd7f801002f14cb3c53c97c
  • Status changed from new to needs_review

New commits:

353638busing __richcmp__ in p1list.pyx

comment:2 Changed 4 years ago by chapoton

  • Keywords python3 richcmp added

comment:3 Changed 4 years ago by saraedum

  • Reviewers set to Julian Rüth

Feel free to set this to positive review once the patchbot is happy.

comment:4 Changed 4 years ago by jdemeyer

Just a comment: there is no need for this:

-cdef class P1List:
+cdef class P1List(object):

since a cdef class is automatically a new-style class. It doesn't hurt though...

comment:5 Changed 4 years ago by chapoton

  • Status changed from needs_review to positive_review


comment:6 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/24899 to 353638bc759a87620fd7f801002f14cb3c53c97c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.