Opened 5 years ago
Closed 4 years ago
#24885 closed enhancement (fixed)
Add helper function to preload some libraries if necessary
| Reported by: | Erik Bray | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-8.3 |
| Component: | build | Keywords: | |
| Cc: | Vincent Delecroix, Samuel Lelièvre | Merged in: | |
| Authors: | Erik Bray | Reviewers: | Vincent Delecroix |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 3ddb719 (Commits, GitHub, GitLab) | Commit: | 3ddb7199ac6251b0c397a6c0ae290e6e0f6b64ef |
| Dependencies: | Stopgaps: |
Status badges
Description (last modified by )
Following my comments on #24575 I think it might be useful to have a generic helper function for implementing my workaround there.
For now it is Linux-only since we've only explicitly encountered this problem on Linux. I believe LD_PRELOAD may be supported on newer versions of Cygwin, but I haven't specifically encountered the need for this workaround there. It would also have to work a bit differently on OSX (which uses DYLD_INSERT_LIBRARY for this purpose). Again, the need hasn't been specifically encountered on that platform. I'm not sure about other unices either.
Change History (10)
comment:1 Changed 5 years ago by
| Cc: | Vincent Delecroix added |
|---|
comment:2 Changed 5 years ago by
| Authors: | → Erik Bray |
|---|---|
| Branch: | → u/embray/build/ticket-24885 |
| Commit: | → ba1b5ee8075c0a03883a42003d19f08983e4e9be |
| Status: | new → needs_review |
comment:3 Changed 5 years ago by
| Cc: | Samuel Lelièvre added |
|---|---|
| Description: | modified (diff) |
comment:4 Changed 4 years ago by
This might be a necessary clutch to get something working, but it is also always a bug in the package build system. We should be working with upstream to point out the issue and fix their build system, not add a framework to Sage so we can ignore those bugs...
comment:5 Changed 4 years ago by
I agree it's ugly, but I don't agree particularly agree that it's an upstream bug. I can think of other cases where having something like this might be useful as well.
The best fix of all for this, from a Sage perspective, is not build and install our own libgc at all if it isn't needed :)
comment:6 Changed 4 years ago by
| Milestone: | sage-8.2 → sage-8.3 |
|---|
comment:7 Changed 4 years ago by
| Commit: | ba1b5ee8075c0a03883a42003d19f08983e4e9be → 3ddb7199ac6251b0c397a6c0ae290e6e0f6b64ef |
|---|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
| 3ddb719 | Add helper function that implements the workaround from https://trac.sagemath.org/ticket/24575 more generically.
|
comment:9 Changed 4 years ago by
| Reviewers: | → Vincent Delecroix |
|---|---|
| Status: | needs_review → positive_review |
Replying to embray:
Rebased. IMO this may still be useful...
Agree. But it is also hard to check without a usecase. Since it is independent of anything else I am setting a positive review.
comment:10 Changed 4 years ago by
| Branch: | u/embray/build/ticket-24885 → 3ddb7199ac6251b0c397a6c0ae290e6e0f6b64ef |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
New commits:
Add helper function that implements the workaround from https://trac.sagemath.org/ticket/24575 more generically.