Opened 4 years ago
Last modified 4 years ago
#24884 closed defect
Matrix-related fixes in differential geometry — at Version 2
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.2 |
Component: | geometry | Keywords: | |
Cc: | egourgoulhon, tscrim | Merged in: | |
Authors: | Jeroen Demeyer | Reviewers: | |
Report Upstream: | N/A | Work issues: | |
Branch: | u/jdemeyer/matrix_related_fixes_in_differential_geometry (Commits, GitHub, GitLab) | Commit: | bd532ab6734f5a87df0c237f75105c92c1158c3d |
Dependencies: | Stopgaps: |
Description (last modified by )
These are changes which are needed because of #24742.
src/sage/schemes/riemann_surfaces/riemann_surface.py
are needed because #24742 will disallow passing strings to the matrix constructor. It's a rarely used feature and hard to get right properly.
src/sage/tensor/modules/comp.py
: I needed to change_get_list()
but I have to say that I don't understand what the code is supposed to do. I wrote the code the way I did mainly to pass doctests, not because it's the right thing to do. I also added some documentation to reflect better what the_get_list()
method does.
src/sage/manifolds/differentiable/metric.py
: this is a consequence of the change in 2. and it looks like a sensible change.
Change History (2)
comment:1 Changed 4 years ago by
- Branch set to u/jdemeyer/matrix_related_fixes_in_differential_geometry
comment:2 Changed 4 years ago by
- Commit set to bd532ab6734f5a87df0c237f75105c92c1158c3d
- Description modified (diff)
- Status changed from new to needs_review
Note: See
TracTickets for help on using
tickets.
New commits:
Matrix-related fixes in differential geometry