id summary reporter owner description type status priority milestone component resolution keywords cc merged author reviewer upstream work_issues branch commit dependencies stopgaps
24884 Matrix-related fixes in differential geometry jdemeyer "These are changes which are needed because of #24742.
1. `src/sage/schemes/riemann_surfaces/riemann_surface.py`: #24742 will disallow passing strings to the matrix constructor. It's a rarely used feature and hard to get right properly. The fix is easy: pass actual elements of the ring instead of the generator names. This is clearly the right thing to do.
2. `src/sage/tensor/modules/comp.py`: I needed to change `_get_list()` but I have to say that I don't understand what the code is supposed to do. I wrote the code the way I did mainly to pass doctests. I also added some documentation to reflect better what the `_get_list()` method does. I also got rid of the evil `try`/`except` block trying to construct a matrix but happily returning a list if that failed.
3. `src/sage/manifolds/differentiable/metric.py`: this is a consequence of the change in 2. and it looks like a sensible change." defect closed major sage-8.2 geometry fixed egourgoulhon tscrim Jeroen Demeyer, Eric Gourgoulhon Travis Scrimshaw N/A 6ae84f147a2209e0396d508c77b4c86e706f3227 6ae84f147a2209e0396d508c77b4c86e706f3227