Changes between Version 3 and Version 4 of Ticket #24884


Ignore:
Timestamp:
03/02/18 10:14:26 (4 years ago)
Author:
jdemeyer
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #24884 – Description

    v3 v4  
    331. `src/sage/schemes/riemann_surfaces/riemann_surface.py`: #24742 will disallow passing strings to the matrix constructor. It's a rarely used feature and hard to get right properly. The fix is easy: pass actual elements of the ring instead of the generator names. This is clearly the right thing to do.
    44
    5 2. `src/sage/tensor/modules/comp.py`: I needed to change `_get_list()` but I have to say that I don't understand what the code is supposed to do. I wrote the code the way I did mainly to pass doctests. I also added some documentation to reflect better what the `_get_list()` method does.
     52. `src/sage/tensor/modules/comp.py`: I needed to change `_get_list()` but I have to say that I don't understand what the code is supposed to do. I wrote the code the way I did mainly to pass doctests. I also added some documentation to reflect better what the `_get_list()` method does. I also got rid of the evil `try`/`except` block trying to construct a matrix but happily returning a list if that failed.
    66
    773. `src/sage/manifolds/differentiable/metric.py`: this is a consequence of the change in 2. and it looks like a sensible change.