Changes between Version 2 and Version 3 of Ticket #24884


Ignore:
Timestamp:
03/02/18 10:13:08 (2 years ago)
Author:
jdemeyer
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #24884 – Description

    v2 v3  
    11These are changes which are needed because of #24742.
    22
    3 1. `src/sage/schemes/riemann_surfaces/riemann_surface.py` are needed because #24742 will disallow passing strings to the matrix constructor. It's a rarely used feature and hard to get right properly.
     31. `src/sage/schemes/riemann_surfaces/riemann_surface.py`: #24742 will disallow passing strings to the matrix constructor. It's a rarely used feature and hard to get right properly. The fix is easy: pass actual elements of the ring instead of the generator names. This is clearly the right thing to do.
    44
    5 2. `src/sage/tensor/modules/comp.py`: I needed to change `_get_list()` but I have to say that I don't understand what the code is supposed to do. I wrote the code the way I did mainly to pass doctests, not because it's the right thing to do. I also added some documentation to reflect better what the `_get_list()` method does.
     52. `src/sage/tensor/modules/comp.py`: I needed to change `_get_list()` but I have to say that I don't understand what the code is supposed to do. I wrote the code the way I did mainly to pass doctests. I also added some documentation to reflect better what the `_get_list()` method does.
    66
    773. `src/sage/manifolds/differentiable/metric.py`: this is a consequence of the change in 2. and it looks like a sensible change.