Changes between Initial Version and Version 2 of Ticket #24884


Ignore:
Timestamp:
03/02/18 10:11:19 (2 years ago)
Author:
jdemeyer
Comment:

New commits:

​bd532abMatrix-related fixes in differential geometry

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #24884

    • Property Status changed from new to needs_review
    • Property Commit changed from to bd532ab6734f5a87df0c237f75105c92c1158c3d
    • Property Branch changed from to u/jdemeyer/matrix_related_fixes_in_differential_geometry

  • Ticket #24884 – Description

    initial v2  
    11These are changes which are needed because of #24742.
     2
     31. `src/sage/schemes/riemann_surfaces/riemann_surface.py` are needed because #24742 will disallow passing strings to the matrix constructor. It's a rarely used feature and hard to get right properly.
     4
     52. `src/sage/tensor/modules/comp.py`: I needed to change `_get_list()` but I have to say that I don't understand what the code is supposed to do. I wrote the code the way I did mainly to pass doctests, not because it's the right thing to do. I also added some documentation to reflect better what the `_get_list()` method does.
     6
     73. `src/sage/manifolds/differentiable/metric.py`: this is a consequence of the change in 2. and it looks like a sensible change.