Changes between Version 1 and Version 2 of Ticket #24884, comment 10


Ignore:
Timestamp:
03/03/18 14:45:17 (2 years ago)
Author:
egourgoulhon
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #24884, comment 10

    v1 v2  
    2626        return resu
    2727}}}
    28 In this way, there is no special treatment for strings or whatever else that is not a ring, since the test `if parent(resu[0][0]) in Rings()` will return false in this case. For tensor field components, the treatment is now at the level of `ChartFunctionRing` (there is no longer any reference to the internal representation via `_express` and `expr()`), so it works for both `SR` and `!SymPy`. In particular the doctest in `src/sage/manifolds/differentiable/metric.py` now displays a matrix of !SymPy objects, and no longer a list, which is an improvement! Thanks for having triggered it!
     28In this way, there is no special treatment for strings or whatever else that is not a ring, since the test `if parent(resu[0][0]) in Rings()` will return false in this case. For tensor field components, the treatment is now at the level of `ChartFunctionRing` (there is no longer any reference to the internal representation via `_express` and `expr()`), so it works for both `SR` and !SymPy. In particular the doctest in `src/sage/manifolds/differentiable/metric.py` now displays a matrix of !SymPy objects, and no longer a list, which is an improvement! Thanks for having triggered it!
    2929
    3030I've pushed these changes in the new branch `public/manifolds/matrix_related_fixes_in_differential_geometry`, which is based on your branch (simply one commit ahead). I am attaching it to the ticket.