Opened 4 years ago

Closed 4 years ago

#24864 closed defect (fixed)

bug in TorsionQuadraticForm.normal_form()

Reported by: sbrandhorst Owned by:
Priority: critical Milestone: sage-8.2
Component: quadratic forms Keywords:
Cc: Merged in:
Authors: Simon Brandhorst Reviewers: Paolo Menegatti
Report Upstream: N/A Work issues:
Branch: 2babaae (Commits, GitHub, GitLab) Commit: 2babaae5c749a2d558095ae5a4c973df13501e23
Dependencies: Stopgaps:

Status badges

Description

sage: L1=IntegralLattice(matrix([[-4,0,0],[0,4,0],[0,0,-2]]))
sage: AL1=L1.discriminant_group()
sage: L2=IntegralLattice(matrix([[-4,0,0],[0,-4,0],[0,0,2]]))
sage: AL2=L2.discriminant_group()
sage: AL1.normal_form()
Finite quadratic module over Integer Ring with invariants (2, 4, 4)
Gram matrix of the quadratic form with values in Q/2Z:
[1/4   0   0]
[  0 5/4   0]
[  0   0 1/2]
sage: AL2.normal_form()
Finite quadratic module over Integer Ring with invariants (2, 4, 4)
Gram matrix of the quadratic form with values in Q/2Z:
[7/4   0   0]
[  0 7/4   0]
[  0   0 1/2]

but:

sage: [x,y,z]=AL2.smith_form_gens()
sage: AL2.submodule_with_gens([x+z,y+x-2*z,x-2*z-2*y])
Finite quadratic module over Integer Ring with invariants (2, 4, 4)
Gram matrix of the quadratic form with values in Q/2Z:
[1/4   0   0]
[  0 5/4   0]
[  0   0 1/2]

Change History (13)

comment:1 Changed 4 years ago by sbrandhorst

  • Authors set to Simon Brandhorst
  • Component changed from PLEASE CHANGE to quadratic forms
  • Type changed from PLEASE CHANGE to defect

comment:2 Changed 4 years ago by sbrandhorst

  • Branch set to u/sbrandhorst/bug_in_torsionquadraticform_normal_form__

comment:3 Changed 4 years ago by sbrandhorst

  • Commit set to 482517444ea52d76de22771b929ed5310fe74ab5
  • Status changed from new to needs_review

New commits:

4825174Fixed a bug in normal_form of a torsion_quadratic_module

comment:4 Changed 4 years ago by git

  • Commit changed from 482517444ea52d76de22771b929ed5310fe74ab5 to 893ba1c1112acccb24eb64da9abb04c428e8f76f

Branch pushed to git repo; I updated commit sha1. New commits:

893ba1ctrivial doc change

comment:5 Changed 4 years ago by pmenegat

I've done some tests and it seems ok to me

comment:6 Changed 4 years ago by pmenegat

  • Status changed from needs_review to positive_review

comment:7 Changed 4 years ago by sbrandhorst

  • Reviewers set to Paolo Menegatti

Thank you for the review. If you review something, please remember to put your name in the reviewers field. :)

comment:8 Changed 4 years ago by pmenegat

I will remember for the next time

comment:9 Changed 4 years ago by vbraun

  • Status changed from positive_review to needs_work

Merge conflict

comment:10 Changed 4 years ago by sbrandhorst

  • Priority changed from major to critical

I will merge in the next beta as soon as it is available.

comment:11 Changed 4 years ago by git

  • Commit changed from 893ba1c1112acccb24eb64da9abb04c428e8f76f to 2babaae5c749a2d558095ae5a4c973df13501e23

Branch pushed to git repo; I updated commit sha1. New commits:

2babaaeMerge branch 'develop' into t/24864/bug_in_torsionquadraticform_normal_form__

comment:12 Changed 4 years ago by sbrandhorst

  • Status changed from needs_work to positive_review

comment:13 Changed 4 years ago by vbraun

  • Branch changed from u/sbrandhorst/bug_in_torsionquadraticform_normal_form__ to 2babaae5c749a2d558095ae5a4c973df13501e23
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.