Opened 5 years ago
Closed 5 years ago
#24860 closed defect (fixed)
Building brial should use -std=gnu++11 on Cygwin
Reported by: | embray | Owned by: | |
---|---|---|---|
Priority: | critical | Milestone: | sage-8.2 |
Component: | porting: Cygwin | Keywords: | brial |
Cc: | Merged in: | ||
Authors: | Erik Bray | Reviewers: | Jeroen Demeyer |
Report Upstream: | N/A | Work issues: | |
Branch: | 9495472 (Commits, GitHub, GitLab) | Commit: | 949547224b8b05d1e4e0deafe90db0fdf9b09b0a |
Dependencies: | Stopgaps: |
Description (last modified by )
This is similar to #24192. On my Cygwin brial actually builds fine with -std=c++11
, but one person reported a problem with this, and that using -std=gnu+11
fixed it.
Change History (4)
comment:1 Changed 5 years ago by
Description: | modified (diff) |
---|---|
Priority: | minor → critical |
comment:2 Changed 5 years ago by
Authors: | → Erik Bray |
---|---|
Branch: | → u/embray/cygwin/ticket-24860 |
Commit: | → 949547224b8b05d1e4e0deafe90db0fdf9b09b0a |
Status: | new → needs_review |
New commits:
9495472 | Fix brial build on newer versions of Cygwin
|
comment:3 Changed 5 years ago by
Reviewers: | → Jeroen Demeyer |
---|---|
Status: | needs_review → positive_review |
Given that this only affects Cygwin, I'll happily give this positive review.
comment:4 Changed 5 years ago by
Branch: | u/embray/cygwin/ticket-24860 → 949547224b8b05d1e4e0deafe90db0fdf9b09b0a |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
I did some digging and it seems this affects Cygwin installs newer than mine, so we should definitely get this fixed then.