Opened 5 years ago

Closed 5 years ago

#24851 closed enhancement (fixed)

fixing a wrong doc construction

Reported by: Frédéric Chapoton Owned by:
Priority: major Milestone: sage-8.2
Component: documentation Keywords:
Cc: Erik Bray, Jeroen Demeyer Merged in:
Authors: Frédéric Chapoton Reviewers: Erik Bray
Report Upstream: N/A Work issues:
Branch: 9d6e1aa (Commits, GitHub, GitLab) Commit: 9d6e1aa1b63a6a34326d3cfafbdfd6c18083ab08
Dependencies: Stopgaps:

Status badges


that is not compatible with python3

Change History (3)

comment:1 Changed 5 years ago by Frédéric Chapoton

Branch: u/chapoton/24851
Commit: 9d6e1aa1b63a6a34326d3cfafbdfd6c18083ab08
Status: newneeds_review

New commits:

9d6e1aafixing a wrong doc construction

comment:2 Changed 5 years ago by Erik Bray

Reviewers: Erik Bray
Status: needs_reviewpositive_review

For what it's worth, this solution from my py3 branch also works:

  • src/sage/coding/

    diff --git a/src/sage/coding/ b/src/sage/coding/
    index 1f8be03..1dad583 100644
    a b AUTHORS: 
     22from six import get_unbound_function as get_func
    2224from sage.misc.abstract_method import abstract_method
    2325from sage.structure.sage_object import SageObject
    class Decoder(SageObject): 
    362364        """
    363365        raise NotImplementedError
    365 Decoder._instance_decoder_type.__func__.__doc__ = Decoder.decoder_type.__doc__
     367get_func(Decoder._instance_decoder_type).__doc__ = Decoder.decoder_type.__doc__
    367369class DecodingError(Exception):
    368370    r"""

But I agree with your patch--in this case (particularly since it's just an internal method) it's really not important to be doing this. But you can use something like the above for future cases if applicable.

comment:3 Changed 5 years ago by Volker Braun

Branch: u/chapoton/248519d6e1aa1b63a6a34326d3cfafbdfd6c18083ab08
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.