#24851 closed enhancement (fixed)

fixing a wrong doc construction

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.2
Component: documentation Keywords:
Cc: embray, jdemeyer Merged in:
Authors: Frédéric Chapoton Reviewers: Erik Bray
Report Upstream: N/A Work issues:
Branch: 9d6e1aa (Commits) Commit: 9d6e1aa1b63a6a34326d3cfafbdfd6c18083ab08
Dependencies: Stopgaps:

Description

that is not compatible with python3

Change History (3)

comment:1 Changed 20 months ago by chapoton

  • Branch set to u/chapoton/24851
  • Commit set to 9d6e1aa1b63a6a34326d3cfafbdfd6c18083ab08
  • Status changed from new to needs_review

New commits:

9d6e1aafixing a wrong doc construction

comment:2 Changed 20 months ago by embray

  • Reviewers set to Erik Bray
  • Status changed from needs_review to positive_review

For what it's worth, this solution from my py3 branch also works:

  • src/sage/coding/decoder.py

    diff --git a/src/sage/coding/decoder.py b/src/sage/coding/decoder.py
    index 1f8be03..1dad583 100644
    a b AUTHORS: 
    1919#                  http://www.gnu.org/licenses/
    2020#*****************************************************************************
    2121
     22from six import get_unbound_function as get_func
     23
    2224from sage.misc.abstract_method import abstract_method
    2325from sage.structure.sage_object import SageObject
    2426
    class Decoder(SageObject): 
    362364        """
    363365        raise NotImplementedError
    364366
    365 Decoder._instance_decoder_type.__func__.__doc__ = Decoder.decoder_type.__doc__
     367get_func(Decoder._instance_decoder_type).__doc__ = Decoder.decoder_type.__doc__
    366368
    367369class DecodingError(Exception):
    368370    r"""

But I agree with your patch--in this case (particularly since it's just an internal method) it's really not important to be doing this. But you can use something like the above for future cases if applicable.

comment:3 Changed 20 months ago by vbraun

  • Branch changed from u/chapoton/24851 to 9d6e1aa1b63a6a34326d3cfafbdfd6c18083ab08
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.