Opened 3 years ago

Closed 3 years ago

#24849 closed enhancement (fixed)

Implement (sub)direct sums of polytopes

Reported by: jipilab Owned by:
Priority: major Milestone: sage-8.3
Component: geometry Keywords: days93, polytope
Cc: vdelecroix, moritz, mkoeppe, chapoton Merged in:
Authors: Jean-Philippe Labbé Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: ffe21e2 (Commits, GitHub, GitLab) Commit: ffe21e24d56b3508d32e3c63e35bd66a7b042b89
Dependencies: #24848, #22572 Stopgaps:

Status badges

Description (last modified by jipilab)

From ​​https://www.csun.edu/~ctoth/Handbook/chap15.pdf:

The (d+d)-dimensional polytope P⊕Q:=conv({(p,0)∈R(d+d')|p∈P}∪{(0,p')∈R(d+d')|q∈Q}). Thus the subdirect sum P⊕Q is a projection of the join P∗Q. The join is implemented in #24848.

Change History (12)

comment:1 Changed 3 years ago by jipilab

  • Branch set to u/jipilab/24849
  • Commit set to 6eb082501f7fee5e1fe659411ba4028c8a978beb
  • Dependencies set to #24848, #22572
  • Description modified (diff)

New commits:

​6eb0825first version of (sub)direct sum

comment:2 Changed 3 years ago by git

  • Commit changed from 6eb082501f7fee5e1fe659411ba4028c8a978beb to b06397557db3de35303736e79faef44d07076ee9

Branch pushed to git repo; I updated commit sha1. New commits:

​b063975typo

comment:3 Changed 3 years ago by jipilab

  • Status changed from new to needs_review

comment:4 Changed 3 years ago by git

  • Commit changed from b06397557db3de35303736e79faef44d07076ee9 to d0242f35e449ee63320eb52bddc285d47363625c

Branch pushed to git repo; I updated commit sha1. New commits:

​d0242f3removed translation from direct sum

comment:5 Changed 3 years ago by git

  • Commit changed from d0242f35e449ee63320eb52bddc285d47363625c to 0295def9ab8b166e553895c8e34d1d13a2104641

Branch pushed to git repo; I updated commit sha1. New commits:

​0295defwhitespaces

comment:6 Changed 3 years ago by git

  • Commit changed from 0295def9ab8b166e553895c8e34d1d13a2104641 to 2457e9791c41ba408fee5295053cfb64f814b2a2

Branch pushed to git repo; I updated commit sha1. New commits:

​2457e97Conventions in docstring

comment:7 Changed 3 years ago by git

  • Commit changed from 2457e9791c41ba408fee5295053cfb64f814b2a2 to a1aabfa56ffc0694033e3c5c8653b6b87ba8f889

Branch pushed to git repo; I updated commit sha1. New commits:

​c807893first version of the join
​a14d2c7pep8
​347f99fMade docstring corrections
​a1aabfaMerge branch '24848' into 24849

comment:8 Changed 3 years ago by chapoton

if the Author field is empty, no patchbot will look at the ticket..

comment:9 Changed 3 years ago by jipilab

  • Authors set to Jean-Philippe Labbé

My bad... too many tickets at the same time.

That's good to know!!

comment:10 Changed 3 years ago by git

  • Commit changed from a1aabfa56ffc0694033e3c5c8653b6b87ba8f889 to ffe21e24d56b3508d32e3c63e35bd66a7b042b89

Branch pushed to git repo; I updated commit sha1. New commits:

​ffe21e2Merge branch 'sage8.2.b7' into 24849

comment:11 Changed 3 years ago by chapoton

  • Milestone changed from sage-8.2 to sage-8.3
  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, let it be

comment:12 Changed 3 years ago by vbraun

  • Branch changed from u/jipilab/24849 to ffe21e24d56b3508d32e3c63e35bd66a7b042b89
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.